feat: add semantic color token system #110
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create centralized color tokens at lib/design-system/tokens for rotation, genre, format, and entry type colors. This provides a single source of truth and fixes inconsistencies: - Rotation colors now consistent across all components (H=danger, M=warning, L=success, S=primary) - Fix invalid "info" color in FlowsheetBackendResult (now uses getFormatColor) - Format colors unified (Vinyl=primary, CD=warning, Unknown=neutral) - Remove duplicate GENRE_COLORS/GENRE_VARIANTS from ArtistAvatar - Make ArtistAvatar format prop required (always provided at call sites)
Deploying wxyc-dj with
|
| Latest commit: |
1d23c89
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6057afcf.dj-site.pages.dev |
| Branch Preview URL: | https://feature-semantic-color-token.dj-site.pages.dev |
The locked version (7c1100cd) had RotationFrequency, but the code uses RotationBin which was added in a later version (914d8195).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
lib/design-system/tokensrotationstyles.tsandFlowsheetTrackResult.tsx)FlowsheetBackendResult.tsxTest plan