-
Notifications
You must be signed in to change notification settings - Fork 11
Resolved Bug 956 : Design System > Side Navigation >Error is displaying #2035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR resolves Bug 956 by addressing an error displayed in the Design System Side Navigation. It updates the Side Navigation component and its Storybook story to improve type safety, default prop values, and router usage.
- Updated the Side Navigation component with proper TypeScript interfaces and default prop handling.
- Modified the Storybook story to utilize MemoryRouter and updated the argTypes configuration.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
raaghu-components/src/rds-comp-side-navigation/rds-comp-side-navigation.tsx | Refactored interfaces and updated default values for collapse and lockIconVisible props; adjusted import path for RdsSideNav. |
raaghu-components/src/rds-comp-side-navigation/rds-comp-side-navigation.stories.tsx | Updated the story definition to use an object literal format with MemoryRouter and added controls for new props. |
Comments suppressed due to low confidence (2)
raaghu-components/src/rds-comp-side-navigation/rds-comp-side-navigation.stories.tsx:178
- [nitpick] Verify that using MemoryRouter in the decorator is intentional and provides full coverage for routing scenarios in Storybook.
(Story) => (
raaghu-components/src/rds-comp-side-navigation/rds-comp-side-navigation.tsx:2
- [nitpick] Confirm that the updated import path for RdsSideNav aligns with the project structure and module organization.
import RdsSideNav from '../../../raaghu-elements/src/rds-side-nav/rds-side-nav';
raaghu-components/src/rds-comp-side-navigation/rds-comp-side-navigation.stories.tsx
Outdated
Show resolved
Hide resolved
…e-Navigation-Multiple-issues-in-side-navigation
…e-Navigation-Multiple-issues-in-side-navigation
Description
Screenshots:
Checklist: