Skip to content

chore: does verify + connect in parallel #6970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ganchoradkov wants to merge 1 commit into
base: v2.0
Choose a base branch
from
Draft

chore: does verify + connect in parallel #6970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/sign-client/src/controllers/engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,7 +959,7 @@
const authenticateEventTarget = engineEvent("session_request", authenticateId);

// handle fallback session proposal response
const onSessionConnect = async ({ error, session }: any) => {

Check warning on line 962 in packages/sign-client/src/controllers/engine.ts

View workflow job for this annotation

GitHub Actions / code_style (lint) 

Async arrow function has no 'await' expression
// cleanup listener for authenticate response
this.events.off(authenticateEventTarget, onAuthenticate);
if (error) reject(error);
Expand Down Expand Up @@ -1614,7 +1614,10 @@

const decryptedId = hashMessage(JSON.stringify(proposeSessionPayload));
const attestationId = hashMessage(proposeSessionMessage);
const attestation = await this.client.core.verify.register({ id: attestationId, decryptedId });
const attestation = await Promise.all([
this.client.core.verify.register({ id: attestationId, decryptedId }),
this.client.core.relayer.transportOpen(),
]).then(([attestation]) => attestation);

await this.client.core.relayer.publishCustom({
payload: {
Expand Down
Loading