|
1 | | -# Project Plan: Fix Clippy Errors and Warnings in former and former_meta crates |
| 1 | +# Project Plan |
2 | 2 |
|
3 | | -## Increments |
| 3 | +## Orignal Goal |
4 | 4 |
|
5 | | -* ✅ Increment 1: Address `absurd_extreme_comparisons` error in `derive_tools_meta/src/derive/new.rs` |
6 | | - * Detailed Plan Step 1: Modify the comparison `if fields.len() <= 0` to `if fields.len() == 0` in `derive_tools_meta/src/derive/new.rs`. |
7 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
8 | | - * Verification Strategy: Run `cargo clippy` and ensure the error is resolved. |
9 | | -* ⏳ Increment 2: Address `used_underscore_binding` warnings in `clone_dyn_meta/src/lib.rs` and `derive_tools_meta/src/lib.rs` |
10 | | - * Detailed Plan Step 1: Remove the underscore prefix from the `_attr` argument in the `clone_dyn` and `phantom` functions or use `#[allow(clippy::used_underscore_binding)]`. |
11 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
12 | | - * Verification Strategy: Run `cargo clippy` and ensure the warnings are resolved. |
13 | | -* ⚫ Increment 3: Address `unnecessary_wraps` warnings in `derive_tools_meta/src/derive/deref_mut.rs` |
14 | | - * Detailed Plan Step 1: Remove `Result` from the return type of `generate_unit` and `generate_struct_tuple_fields` functions and adjust the returning expressions accordingly. |
15 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
16 | | - * Verification Strategy: Run `cargo clippy` and ensure the warnings are resolved. |
17 | | -* ⚫ Increment 4: Address `needless_borrow` warnings in `derive_tools_meta/src/derive/deref_mut.rs`, `derive_tools_meta/src/derive/index.rs`, and `derive_tools_meta/src/derive/new.rs` |
18 | | - * Detailed Plan Step 1: Remove unnecessary `&` in the specified locations. |
19 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
20 | | - * Verification Strategy: Run `cargo clippy` and ensure the warnings are resolved. |
21 | | -* ⚫ Increment 5: Address `match_same_arms` warning in `derive_tools_meta/src/derive/index/item_attributes.rs` |
22 | | - * Detailed Plan Step 1: Remove the redundant match arm. |
23 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
24 | | - * Verification Strategy: Run `cargo clippy` and ensure the warning is resolved. |
25 | | -* ⚫ Increment 6: Address `needless_return` warnings in `derive_tools_meta/src/derive/index/item_attributes.rs` and `derive_tools_meta/src/derive/not/field_attributes.rs` |
26 | | - * Detailed Plan Step 1: Remove the `return` keyword in the specified locations. |
27 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
28 | | - * Verification Strategy: Run `cargo clippy` and ensure the warnings are resolved. |
29 | | -* ⚫ Increment 7: Address `match_wildcard_for_single_variants` warning in `derive_tools_meta/src/derive/index/item_attributes.rs` and `derive_tools_meta/src/derive/not/field_attributes.rs` |
30 | | - * Detailed Plan Step 1: Replace the wildcard `_` with `syn::Meta::NameValue(_)` in the specified locations. |
31 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
32 | | - * Verification Strategy: Run `cargo clippy` and ensure the warning is resolved. |
33 | | -* ⚫ Increment 8: Address `default_trait_access` warnings in `derive_tools_meta/src/derive/index/item_attributes.rs` and `derive_tools_meta/src/derive/not/field_attributes.rs` |
34 | | - * Detailed Plan Step 1: Replace `Default::default()` with `ItemAttributeIndex::default()` or `FieldAttributeConfig::default()` in the specified locations. |
35 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
36 | | - * Verification Strategy: Run `cargo clippy` and ensure the warnings are resolved. |
37 | | -* ⚫ Increment 9: Address `uninlined_format_args` warnings in `derive_tools_meta/src/derive/index/item_attributes.rs`, `derive_tools_meta/src/derive/not/field_attributes.rs`, and `derive_tools_meta/src/derive/new.rs` |
38 | | - * Detailed Plan Step 1: Use the variable directly in the format string (e.g., `format!("{key_ident}")` instead of `format!("{}", key_ident)`). |
39 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
40 | | - * Verification Strategy: Run `cargo clippy` and ensure the warnings are resolved. |
41 | | -* ⚫ Increment 10: Address `if_not_else` warning in `derive_tools_meta/src/derive/index_mut.rs` |
42 | | - * Detailed Plan Step 1: Invert the condition and swap the `if` and `else` blocks. |
43 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
44 | | - * Verification Strategy: Run `cargo clippy` and ensure the warning is resolved. |
45 | | -* ⚫ Increment 11: Address `cloned_instead_of_copied` warning in `derive_tools_meta/src/derive/index_mut.rs` |
46 | | - * Detailed Plan Step 1: Replace `.cloned()` with `.copied()` in the specified location. |
47 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
48 | | - * Verification Strategy: Run `cargo clippy` and ensure the warning is resolved. |
49 | | -* ⚫ Increment 12: Address `too_many_lines` warnings in `derive_tools_meta/src/derive/index_mut.rs` and `derive_tools_meta/src/derive/variadic_from.rs` |
50 | | - * Detailed Plan Step 1: Refactor the functions to reduce the number of lines. This might involve extracting parts of the function into smaller, more manageable functions. |
51 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
52 | | - * Verification Strategy: Run `cargo clippy` and ensure the warnings are resolved. |
53 | | -* ⚫ Increment 13: Address `doc_markdown` warnings in `clone_dyn/Readme.md`, `derive_tools_meta/src/derive/index.rs`, `derive_tools_meta/src/lib.rs` and `module/move/sqlx_query/../../../Readme.md` |
54 | | - * Detailed Plan Step 1: Add backticks to the specified items in the documentation. |
55 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
56 | | - * Verification Strategy: Run `cargo clippy` and ensure the warnings are resolved. |
57 | | -* ⚫ Increment 14: Address `empty_line_after_doc_comments` warning in `module/move/graphs_tools_deprecated/src/algo/dfs.rs` |
58 | | - * Detailed Plan Step 1: Remove the empty line after the doc comment. |
59 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
60 | | - * Verification Strategy: Run `cargo clippy` and ensure the warning is resolved. |
61 | | -* ⚫ Increment 15: Address `useless_format` warnings in `module/move/gspread/src/actions/utils.rs` and `module/move/gspread/src/gcore/client.rs` |
62 | | - * Detailed Plan Step 1: Replace `format!( "{}" , var )` with `var.to_string()` |
63 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
64 | | - * Verification Strategy: Run `cargo clippy` and ensure the warnings are resolved. |
65 | | -* ⚫ Increment 16: Address `ptr_arg` warning in `module/move/gspread/src/actions/gspread.rs` |
66 | | - * Detailed Plan Step 1: Replace `&Vec<T>` with `&[T]` |
67 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
68 | | - * Verification Strategy: Run `cargo clippy` and ensure the warning is resolved. |
69 | | -* ⚫ Increment 17: Address `manual_div_ceil` warning in `module/move/gspread/src/actions/gspread.rs` |
70 | | - * Detailed Plan Step 1: Replace manual division with `div_ceil` |
71 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
72 | | - * Verification Strategy: Run `cargo clippy` and ensure the warning is resolved. |
73 | | -* ⚫ Increment 18: Address `needless_return` warning in `module/move/gspread/src/actions/gspread.rs` |
74 | | - * Detailed Plan Step 1: Remove `return` keyword |
75 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
76 | | - * Verification Strategy: Run `cargo clippy` and ensure the warning is resolved. |
77 | | -* ⚫ Increment 19: Address `await_holding_refcell_ref` warnings in `module/move/gspread/src/gcore/client.rs` |
78 | | - * Detailed Plan Step 1: Ensure the reference is dropped before calling `await` |
79 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
80 | | - * Verification Strategy: Run `cargo clippy` and ensure the warnings are resolved. |
81 | | -* ⚫ Increment 20: Address `redundant_field_names` warnings in `module/move/gspread/src/gcore/client.rs`, `module/move/gspread/src/commands/gspread_row.rs` and `module/move/gspread/src/actions/gspread_row_update.rs` |
82 | | - * Detailed Plan Step 1: Replace `field : field` with `field` |
83 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
84 | | - * Verification Strategy: Run `cargo clippy` and ensure the warnings are resolved. |
85 | | -* ⚫ Increment 21: Address `redundant_static_lifetimes` warnings in `module/move/gspread/src/utils/constants.rs` |
86 | | - * Detailed Plan Step 1: Remove `static` lifetime |
87 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
88 | | - * Verification Strategy: Run `cargo clippy` and ensure the warnings are resolved. |
89 | | -* ⚫ Increment 22: Address `match_single_binding` warnings in `module/move/gspread/src/commands/gspread_header.rs`, `module/move/gspread/src/commands/gspread_rows.rs` and `module/move/gspread/src/commands/gspread_clear_custom.rs` and `module/move/gspread/src/commands/gspread_copy.rs` |
90 | | - * Detailed Plan Step 1: Replace `match` with `let` |
91 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
92 | | - * Verification Strategy: Run `cargo clippy` and ensure the warnings are resolved. |
93 | | -* ⚫ Increment 23: Address `manual_unwrap_or` warnings in `module/move/gspread/src/actions/gspread_row_update_custom.rs` |
94 | | - * Detailed Plan Step 1: Replace manual implementation with `unwrap_or_default()` |
95 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
96 | | - * Verification Strategy: Run `cargo clippy` and ensure the warnings are resolved. |
97 | | -* ⚫ Increment 24: Address the error in `module/core/program_tools` |
98 | | - * Detailed Plan Step 1: Investigate the error and apply the necessary changes to fix it. |
99 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
100 | | - * Verification Strategy: Run `cargo clippy` and ensure the error is resolved. |
101 | | -* ⚫ Increment 25: Address the errors in `module/move/refiner` |
102 | | - * Detailed Plan Step 1: Investigate the errors and apply the necessary changes to fix it. |
103 | | - * Crucial Design Rules: [Code Style: Do Not Reformat Arbitrarily](#code-style-do-not-reformat-arbitrarily) |
104 | | - * Verification Strategy: Run `cargo check --workspace` and ensure the errors are resolved. |
105 | | - |
106 | | -## Notes & Insights |
| 5 | +Remove derives FromComponents, ComponentsAssign, ComponentAssign and ComponentFrom from crates former, former_meta, former_types as well as documentations, examples, types and everithing related to these derives and component model. Don't edit other crates. |
0 commit comments