Callbacks implementation for MemberCloner #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Washi1337
requested changes
Aug 7, 2022
Owner
Washi1337
left a comment
Washi1337
left a comment
There was a problem hiding this comment.
Nice, thanks a lot for writing an implementation and tests!
Few things here and there regarding code style inconsistencies (maybe check .editorconfig), but I think the main thing that we probably want to consider changing is making all methods virtual instead of abstract, and moving the OnClonedXXX members into the interface. See comments below.
Other than that, lgtm.
Washi1337
reviewed
Aug 8, 2022
Washi1337
approved these changes
Aug 10, 2022
Owner
Washi1337
left a comment
Washi1337
left a comment
There was a problem hiding this comment.
Nice, thanks a lot. This extension will definitely be useful. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves [#333]