Skip to content

SignatureComparer Improvements #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Washi1337 merged 1 commit into from
Oct 16, 2022
Merged

SignatureComparer Improvements #366

Washi1337 merged 1 commit into from
Oct 16, 2022

Conversation

@ds5678
Copy link
Contributor

@ds5678 ds5678 commented Oct 16, 2022

This pull request:

  • Makes SignatureComparer immutable.
  • Adds a new enum SignatureComparisonFlags for configuring SignatureComparer.
  • Removes IgnoreAssemblyVersionNumbers and AcceptNewerAssemblyVersionNumbers from the public scope.
  • Adds a static property for the Default instance of SignatureComparer.

Washi1337
Washi1337 approved these changes Oct 16, 2022
View reviewed changes
Copy link
Owner

@Washi1337 Washi1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is a good idea. Thanks a lot!

@Washi1337 Washi1337 merged commit e9d9e5d into Washi1337:development Oct 16, 2022
@Washi1337 Washi1337 added enhancement dotnet Issues related to AsmResolver.DotNet labels Oct 16, 2022
@Washi1337 Washi1337 added this to the 5.0.0 milestone Oct 16, 2022
@ds5678 ds5678 deleted the shared-signature-comparer branch October 16, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Washi1337 Washi1337 Washi1337 approved these changes

Assignees

No one assigned

Labels

dotnet Issues related to AsmResolver.DotNet enhancement

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ds5678 @Washi1337