AsmResolver.DotNet.PortablePdbs#681
Draft
Windows10CE wants to merge 14 commits intoWashi1337:developmentfrom
Draft
AsmResolver.DotNet.PortablePdbs#681Windows10CE wants to merge 14 commits intoWashi1337:developmentfrom
Windows10CE wants to merge 14 commits intoWashi1337:developmentfrom
Conversation
5dda80d to
2ea3506
Compare
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6006717 to
65d5db0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
# Conflicts: # src/AsmResolver.DotNet/Serialized/ModuleReaderParameters.cs
32aa884 to
0ab62f4
Compare
Test Results
Failing runs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some information for my future self:
The documented custom debug records are incomplete, Roslyn at least implements more than listed.
Official: https://github.com/dotnet/runtime/blob/main/docs/design/specs/PortablePdb-Metadata.md#language-specific-custom-debug-information-records
Roslyn kinds: https://github.com/dotnet/roslyn/blob/main/src/Dependencies/CodeAnalysis.Debugging/PortableCustomDebugInfoKinds.cs
Diff: name, kind, parent type, blob format, usage
F# probably also has kinds not listed here, look into thoseF# has no additional kinds it only uses like 3 of the ones that Roslyn also uses