Add ISpanFormattable and IUtf8SpanFormattable to Utf8String
#699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditionally implements ISpanFormattable and IUtf8SpanFormattable interfaces for Utf8String when targeting .NET 10.0 or greater. Adds TryFormat and ToString overloads to improve formatting and span-based operations.
Introduced two new tests: one to verify Utf8String formatting with DefaultInterpolatedStringHandler, and another to test TryFormat, buffer writing, and internal caching behavior. These tests improve coverage for Utf8String's formatting and formattable features.
This comment has been minimized.
This comment has been minimized.
Washi1337
requested changes
Dec 17, 2025
Owner
Washi1337
left a comment
Washi1337
left a comment
There was a problem hiding this comment.
Small things but other than that lgtm
Changed preprocessor directives from NET10_0_OR_GREATER to NET6_0_OR_GREATER for ISpanFormattable interface and related methods, ensuring compatibility with .NET 6 and above. Also adjusted #endif placement for clarity.
Cleaned up formatting by removing extra blank lines in TryCopyTo methods of Utf8String.cs for improved code readability.
Test Results
Failing runs |
Washi1337
added
enhancement
dotnet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #698.