Conversation
Test Results
Failing runs❌ AsmResolver.Symbols.Pdb.Tests.Leaves.BuildInfoLeafTest.Entries
❌ AsmResolver.Symbols.Pdb.Tests.Leaves.FunctionIdentifierTest.FunctionType
❌ AsmResolver.Symbols.Pdb.Tests.Leaves.FunctionIdentifierTest.Name
❌ AsmResolver.Symbols.Pdb.Tests.Leaves.StringIdentifierTest.NoSubStrings
❌ AsmResolver.Symbols.Pdb.Tests.Leaves.StringIdentifierTest.SubStrings
❌ AsmResolver.Symbols.Pdb.Tests.Leaves.StringIdentifierTest.Value
❌ AsmResolver.Symbols.Pdb.Tests.Records.BuildInfoSymbolTest.Info
❌ AsmResolver.Symbols.Pdb.Tests.Records.FunctionListSymbolTest.Entries
❌ AsmResolver.Symbols.Pdb.Tests.Records.InlineSiteSymbolTest.Inlinee
|
|
Not sure what is going on here, why are all tests failing with this change? Also, from a design perspective, I don't think it is a good idea to make a public Besides, if we want improved error messages, why wouldn't we just leave the error handling in the respective |
I didn't look into it.
Understood
I will abandon this pull request for now. If I come to this pull request, I think I can address your concerns with a source generator for those methods. It seems like an ideal solution to the problem. |
See previous version: #360