Skip to content

Improved leaf record errors#715

Draft
ds5678 wants to merge 2 commits intoWashi1337:developmentfrom
ds5678:ImprovedLeafRecordErrors
Draft

Improved leaf record errors#715
ds5678 wants to merge 2 commits intoWashi1337:developmentfrom
ds5678:ImprovedLeafRecordErrors

Conversation

@ds5678
Copy link
Copy Markdown
Contributor

@ds5678 ds5678 commented Feb 20, 2026

See previous version: #360

@github-actions
Copy link
Copy Markdown

Test Results

Total Skipped Passed Failed
Unique 2151 5 💤 2142 ✅ 9 ❌
Total 4302 36 💤 4248 ✅ 18 ❌

Failing runs

❌ AsmResolver.Symbols.Pdb.Tests.Leaves.BuildInfoLeafTest.Entries

Class Name: AsmResolver.Symbols.Pdb.Tests.Leaves.BuildInfoLeafTest | Method Name: Entries | This test is always failing.

Failures present in
  • test-results/test-results-ubuntu-24.04-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/_runnervmwffz4_2026-02-20_00_48_48.trx
  • test-results/test-results-windows-2025-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/runneradmin_runnervm2bfby_2026-02-20_00_48_33.trx
❌ test-results/test-results-windows-2025-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/runneradmin_runnervm2bfby_2026-02-20_00_48_33.trx AsmResolver.Symbols.Pdb.Tests.Leaves.BuildInfoLeafTest.Entries

Took 00:00:00.0120610

Failure also present in
  • test-results/test-results-ubuntu-24.04-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/_runnervmwffz4_2026-02-20_00_48_48.trx
Exception message:
System.BadImageFormatException : The ID index 0000100D has an unexpected type (Enum).

Stack trace:

   at AsmResolver.ThrowErrorListener.RegisterException(Exception exception) in /_/src/AsmResolver/ThrowErrorListener.cs:line 29
   at AsmResolver.ErrorListenerExtensions.BadImageAndReturn[T](IErrorListener self, String message) in /_/src/AsmResolver/IErrorListener.cs:line 90
   at AsmResolver.Symbols.Pdb.PdbImage.GetIdLeafRecord[TLeaf](UInt32 idIndex) in /_/src/AsmResolver.Symbols.Pdb/PdbImage.cs:line 347
   at AsmResolver.Symbols.Pdb.Tests.Leaves.BuildInfoLeafTest.Entries() in /_/test/AsmResolver.Symbols.Pdb.Tests/Leaves/BuildInfoLeafTest.cs:line 19
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
❌ AsmResolver.Symbols.Pdb.Tests.Leaves.FunctionIdentifierTest.FunctionType

Class Name: AsmResolver.Symbols.Pdb.Tests.Leaves.FunctionIdentifierTest | Method Name: FunctionType | This test is always failing.

Failures present in
  • test-results/test-results-ubuntu-24.04-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/_runnervmwffz4_2026-02-20_00_48_48.trx
  • test-results/test-results-windows-2025-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/runneradmin_runnervm2bfby_2026-02-20_00_48_33.trx
❌ test-results/test-results-windows-2025-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/runneradmin_runnervm2bfby_2026-02-20_00_48_33.trx AsmResolver.Symbols.Pdb.Tests.Leaves.FunctionIdentifierTest.FunctionType

Took 00:00:00.0003576

Failure also present in
  • test-results/test-results-ubuntu-24.04-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/_runnervmwffz4_2026-02-20_00_48_48.trx
Exception message:
System.BadImageFormatException : The ID index 00001453 has an unexpected type (Structure).

Stack trace:

   at AsmResolver.ThrowErrorListener.RegisterException(Exception exception) in /_/src/AsmResolver/ThrowErrorListener.cs:line 29
   at AsmResolver.ErrorListenerExtensions.BadImageAndReturn[T](IErrorListener self, String message) in /_/src/AsmResolver/IErrorListener.cs:line 90
   at AsmResolver.Symbols.Pdb.PdbImage.GetIdLeafRecord[TLeaf](UInt32 idIndex) in /_/src/AsmResolver.Symbols.Pdb/PdbImage.cs:line 347
   at AsmResolver.Symbols.Pdb.Tests.Leaves.FunctionIdentifierTest.FunctionType() in /_/test/AsmResolver.Symbols.Pdb.Tests/Leaves/FunctionIdentifierTest.cs:line 25
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
❌ AsmResolver.Symbols.Pdb.Tests.Leaves.FunctionIdentifierTest.Name

Class Name: AsmResolver.Symbols.Pdb.Tests.Leaves.FunctionIdentifierTest | Method Name: Name | This test is always failing.

Failures present in
  • test-results/test-results-ubuntu-24.04-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/_runnervmwffz4_2026-02-20_00_48_48.trx
  • test-results/test-results-windows-2025-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/runneradmin_runnervm2bfby_2026-02-20_00_48_33.trx
❌ test-results/test-results-windows-2025-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/runneradmin_runnervm2bfby_2026-02-20_00_48_33.trx AsmResolver.Symbols.Pdb.Tests.Leaves.FunctionIdentifierTest.Name

Took 00:00:00.0032720

Failure also present in
  • test-results/test-results-ubuntu-24.04-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/_runnervmwffz4_2026-02-20_00_48_48.trx
Exception message:
System.BadImageFormatException : The ID index 00001453 has an unexpected type (Structure).

Stack trace:

   at AsmResolver.ThrowErrorListener.RegisterException(Exception exception) in /_/src/AsmResolver/ThrowErrorListener.cs:line 29
   at AsmResolver.ErrorListenerExtensions.BadImageAndReturn[T](IErrorListener self, String message) in /_/src/AsmResolver/IErrorListener.cs:line 90
   at AsmResolver.Symbols.Pdb.PdbImage.GetIdLeafRecord[TLeaf](UInt32 idIndex) in /_/src/AsmResolver.Symbols.Pdb/PdbImage.cs:line 347
   at AsmResolver.Symbols.Pdb.Tests.Leaves.FunctionIdentifierTest.Name() in /_/test/AsmResolver.Symbols.Pdb.Tests/Leaves/FunctionIdentifierTest.cs:line 18
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
❌ AsmResolver.Symbols.Pdb.Tests.Leaves.StringIdentifierTest.NoSubStrings

Class Name: AsmResolver.Symbols.Pdb.Tests.Leaves.StringIdentifierTest | Method Name: NoSubStrings | This test is always failing.

Failures present in
  • test-results/test-results-ubuntu-24.04-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/_runnervmwffz4_2026-02-20_00_48_48.trx
  • test-results/test-results-windows-2025-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/runneradmin_runnervm2bfby_2026-02-20_00_48_33.trx
❌ test-results/test-results-windows-2025-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/runneradmin_runnervm2bfby_2026-02-20_00_48_33.trx AsmResolver.Symbols.Pdb.Tests.Leaves.StringIdentifierTest.NoSubStrings

Took 00:00:00.0001758

Failure also present in
  • test-results/test-results-ubuntu-24.04-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/_runnervmwffz4_2026-02-20_00_48_48.trx
Exception message:
System.BadImageFormatException : The ID index 00001000 has an unexpected type (Structure).

Stack trace:

   at AsmResolver.ThrowErrorListener.RegisterException(Exception exception) in /_/src/AsmResolver/ThrowErrorListener.cs:line 29
   at AsmResolver.ErrorListenerExtensions.BadImageAndReturn[T](IErrorListener self, String message) in /_/src/AsmResolver/IErrorListener.cs:line 90
   at AsmResolver.Symbols.Pdb.PdbImage.GetIdLeafRecord[TLeaf](UInt32 idIndex) in /_/src/AsmResolver.Symbols.Pdb/PdbImage.cs:line 347
   at AsmResolver.Symbols.Pdb.Tests.Leaves.StringIdentifierTest.NoSubStrings() in /_/test/AsmResolver.Symbols.Pdb.Tests/Leaves/StringIdentifierTest.cs:line 26
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
❌ AsmResolver.Symbols.Pdb.Tests.Leaves.StringIdentifierTest.SubStrings

Class Name: AsmResolver.Symbols.Pdb.Tests.Leaves.StringIdentifierTest | Method Name: SubStrings | This test is always failing.

Failures present in
  • test-results/test-results-ubuntu-24.04-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/_runnervmwffz4_2026-02-20_00_48_48.trx
  • test-results/test-results-windows-2025-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/runneradmin_runnervm2bfby_2026-02-20_00_48_33.trx
❌ test-results/test-results-windows-2025-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/runneradmin_runnervm2bfby_2026-02-20_00_48_33.trx AsmResolver.Symbols.Pdb.Tests.Leaves.StringIdentifierTest.SubStrings

Took 00:00:00.0005737

Failure also present in
  • test-results/test-results-ubuntu-24.04-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/_runnervmwffz4_2026-02-20_00_48_48.trx
Exception message:
System.BadImageFormatException : The ID index 0000100C has an unexpected type (FieldList).

Stack trace:

   at AsmResolver.ThrowErrorListener.RegisterException(Exception exception) in /_/src/AsmResolver/ThrowErrorListener.cs:line 29
   at AsmResolver.ErrorListenerExtensions.BadImageAndReturn[T](IErrorListener self, String message) in /_/src/AsmResolver/IErrorListener.cs:line 90
   at AsmResolver.Symbols.Pdb.PdbImage.GetIdLeafRecord[TLeaf](UInt32 idIndex) in /_/src/AsmResolver.Symbols.Pdb/PdbImage.cs:line 347
   at AsmResolver.Symbols.Pdb.Tests.Leaves.StringIdentifierTest.SubStrings() in /_/test/AsmResolver.Symbols.Pdb.Tests/Leaves/StringIdentifierTest.cs:line 33
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
❌ AsmResolver.Symbols.Pdb.Tests.Leaves.StringIdentifierTest.Value

Class Name: AsmResolver.Symbols.Pdb.Tests.Leaves.StringIdentifierTest | Method Name: Value | This test is always failing.

Failures present in
  • test-results/test-results-ubuntu-24.04-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/_runnervmwffz4_2026-02-20_00_48_48.trx
  • test-results/test-results-windows-2025-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/runneradmin_runnervm2bfby_2026-02-20_00_48_33.trx
❌ test-results/test-results-windows-2025-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/runneradmin_runnervm2bfby_2026-02-20_00_48_33.trx AsmResolver.Symbols.Pdb.Tests.Leaves.StringIdentifierTest.Value

Took 00:00:00.0011114

Failure also present in
  • test-results/test-results-ubuntu-24.04-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/_runnervmwffz4_2026-02-20_00_48_48.trx
Exception message:
System.BadImageFormatException : The ID index 00001000 has an unexpected type (Structure).

Stack trace:

   at AsmResolver.ThrowErrorListener.RegisterException(Exception exception) in /_/src/AsmResolver/ThrowErrorListener.cs:line 29
   at AsmResolver.ErrorListenerExtensions.BadImageAndReturn[T](IErrorListener self, String message) in /_/src/AsmResolver/IErrorListener.cs:line 90
   at AsmResolver.Symbols.Pdb.PdbImage.GetIdLeafRecord[TLeaf](UInt32 idIndex) in /_/src/AsmResolver.Symbols.Pdb/PdbImage.cs:line 347
   at AsmResolver.Symbols.Pdb.Tests.Leaves.StringIdentifierTest.Value() in /_/test/AsmResolver.Symbols.Pdb.Tests/Leaves/StringIdentifierTest.cs:line 19
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
❌ AsmResolver.Symbols.Pdb.Tests.Records.BuildInfoSymbolTest.Info

Class Name: AsmResolver.Symbols.Pdb.Tests.Records.BuildInfoSymbolTest | Method Name: Info | This test is always failing.

Failures present in
  • test-results/test-results-ubuntu-24.04-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/_runnervmwffz4_2026-02-20_00_48_48.trx
  • test-results/test-results-windows-2025-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/runneradmin_runnervm2bfby_2026-02-20_00_48_33.trx
❌ test-results/test-results-windows-2025-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/runneradmin_runnervm2bfby_2026-02-20_00_48_33.trx AsmResolver.Symbols.Pdb.Tests.Records.BuildInfoSymbolTest.Info

Took 00:00:00.0057574

Failure also present in
  • test-results/test-results-ubuntu-24.04-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/_runnervmwffz4_2026-02-20_00_48_48.trx
Exception message:
System.BadImageFormatException : The ID index 0000100D has an unexpected type (Enum).

Stack trace:

   at AsmResolver.ThrowErrorListener.RegisterException(Exception exception) in /_/src/AsmResolver/ThrowErrorListener.cs:line 29
   at AsmResolver.ErrorListenerExtensions.BadImageAndReturn[T](IErrorListener self, String message) in /_/src/AsmResolver/IErrorListener.cs:line 90
   at AsmResolver.Symbols.Pdb.PdbImage.GetIdLeafRecord[TLeaf](UInt32 idIndex) in /_/src/AsmResolver.Symbols.Pdb/PdbImage.cs:line 347
   at AsmResolver.Symbols.Pdb.Records.Serialized.SerializedBuildInfoSymbol.GetInfo() in /_/src/AsmResolver.Symbols.Pdb/Records/Serialized/SerializedBuildInfoSymbol.cs:line 28
   at AsmResolver.Symbols.Pdb.Records.BuildInfoSymbol.<get_Info>g__InitializeValue|5_0() in /_/artifacts/src/obj/AsmResolver.Symbols.Pdb/release_net10.0/AsmResolver.SourceGenerators/AsmResolver.SourceGenerators.LazyPropertyGenerator/BuildInfoSymbol.g.cs:line 31
   at AsmResolver.Symbols.Pdb.Records.BuildInfoSymbol.get_Info() in /_/artifacts/src/obj/AsmResolver.Symbols.Pdb/release_net10.0/AsmResolver.SourceGenerators/AsmResolver.SourceGenerators.LazyPropertyGenerator/BuildInfoSymbol.g.cs:line 22
   at AsmResolver.Symbols.Pdb.Tests.Records.BuildInfoSymbolTest.Info() in /_/test/AsmResolver.Symbols.Pdb.Tests/Records/BuildInfoSymbolTest.cs:line 20
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
❌ AsmResolver.Symbols.Pdb.Tests.Records.FunctionListSymbolTest.Entries

Class Name: AsmResolver.Symbols.Pdb.Tests.Records.FunctionListSymbolTest | Method Name: Entries | This test is always failing.

Failures present in
  • test-results/test-results-ubuntu-24.04-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/_runnervmwffz4_2026-02-20_00_48_48.trx
  • test-results/test-results-windows-2025-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/runneradmin_runnervm2bfby_2026-02-20_00_48_33.trx
❌ test-results/test-results-windows-2025-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/runneradmin_runnervm2bfby_2026-02-20_00_48_33.trx AsmResolver.Symbols.Pdb.Tests.Records.FunctionListSymbolTest.Entries

Took 00:00:00.0090525

Failure also present in
  • test-results/test-results-ubuntu-24.04-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/_runnervmwffz4_2026-02-20_00_48_48.trx
Exception message:
System.BadImageFormatException : The ID index 00001466 has an unexpected type (Pointer).

Stack trace:

   at AsmResolver.ThrowErrorListener.RegisterException(Exception exception) in /_/src/AsmResolver/ThrowErrorListener.cs:line 29
   at AsmResolver.ErrorListenerExtensions.BadImageAndReturn[T](IErrorListener self, String message) in /_/src/AsmResolver/IErrorListener.cs:line 90
   at AsmResolver.Symbols.Pdb.PdbImage.GetIdLeafRecord[TLeaf](UInt32 idIndex) in /_/src/AsmResolver.Symbols.Pdb/PdbImage.cs:line 347
   at AsmResolver.Symbols.Pdb.Records.Serialized.SerializedFunctionListSymbol.GetEntries() in /_/src/AsmResolver.Symbols.Pdb/Records/Serialized/SerializedFunctionListSymbol.cs:line 46
   at AsmResolver.Symbols.Pdb.Records.FunctionListSymbol.get_Entries() in /_/src/AsmResolver.Symbols.Pdb/Records/FunctionListSymbol.cs:line 52
   at AsmResolver.Symbols.Pdb.Tests.Records.FunctionListSymbolTest.Entries() in /_/test/AsmResolver.Symbols.Pdb.Tests/Records/FunctionListSymbolTest.cs:line 23
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
❌ AsmResolver.Symbols.Pdb.Tests.Records.InlineSiteSymbolTest.Inlinee

Class Name: AsmResolver.Symbols.Pdb.Tests.Records.InlineSiteSymbolTest | Method Name: Inlinee | This test is always failing.

Failures present in
  • test-results/test-results-ubuntu-24.04-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/_runnervmwffz4_2026-02-20_00_48_48.trx
  • test-results/test-results-windows-2025-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/runneradmin_runnervm2bfby_2026-02-20_00_48_33.trx
❌ test-results/test-results-windows-2025-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/runneradmin_runnervm2bfby_2026-02-20_00_48_33.trx AsmResolver.Symbols.Pdb.Tests.Records.InlineSiteSymbolTest.Inlinee

Took 00:00:00.0110432

Failure also present in
  • test-results/test-results-ubuntu-24.04-x64/test/AsmResolver.Symbols.Pdb.Tests/TestResults/_runnervmwffz4_2026-02-20_00_48_48.trx
Exception message:
System.BadImageFormatException : The ID index 000014BC has an unexpected type (Structure).

Stack trace:

   at AsmResolver.ThrowErrorListener.RegisterException(Exception exception) in /_/src/AsmResolver/ThrowErrorListener.cs:line 29
   at AsmResolver.ErrorListenerExtensions.BadImageAndReturn[T](IErrorListener self, String message) in /_/src/AsmResolver/IErrorListener.cs:line 90
   at AsmResolver.Symbols.Pdb.PdbImage.GetIdLeafRecord[TLeaf](UInt32 idIndex) in /_/src/AsmResolver.Symbols.Pdb/PdbImage.cs:line 347
   at AsmResolver.Symbols.Pdb.Records.Serialized.SerializedInlineSiteSymbol.GetInlinee() in /_/src/AsmResolver.Symbols.Pdb/Records/Serialized/SerializedInlineSiteSymbol.cs:line 35
   at AsmResolver.Symbols.Pdb.Records.InlineSiteSymbol.<get_Inlinee>g__InitializeValue|9_0() in /_/artifacts/src/obj/AsmResolver.Symbols.Pdb/release_net10.0/AsmResolver.SourceGenerators/AsmResolver.SourceGenerators.LazyPropertyGenerator/InlineSiteSymbol.g.cs:line 31
   at AsmResolver.Symbols.Pdb.Records.InlineSiteSymbol.get_Inlinee() in /_/artifacts/src/obj/AsmResolver.Symbols.Pdb/release_net10.0/AsmResolver.SourceGenerators/AsmResolver.SourceGenerators.LazyPropertyGenerator/InlineSiteSymbol.g.cs:line 22
   at AsmResolver.Symbols.Pdb.Tests.Records.InlineSiteSymbolTest.Inlinee() in /_/test/AsmResolver.Symbols.Pdb.Tests/Records/InlineSiteSymbolTest.cs:line 22
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

@Washi1337
Copy link
Copy Markdown
Owner

Washi1337 commented Feb 20, 2026

Not sure what is going on here, why are all tests failing with this change?

Also, from a design perspective, I don't think it is a good idea to make a public GetLeafRecord dependent on an error listener. That goes against the design of other APIs (e.g.,ModuleDefinition.LookupMember also doesn't depend on the error listener of the underlying reader).

Besides, if we want improved error messages, why wouldn't we just leave the error handling in the respective GetX initializer methods? Wouldn't that allow for much more fine-grained diagnostics as it is now?

@Washi1337 Washi1337 added enhancement pdb Issues related to AsmResolver.Symbols.Pdb labels Feb 20, 2026
@ds5678 ds5678 marked this pull request as draft February 20, 2026 20:10
@ds5678
Copy link
Copy Markdown
Contributor Author

ds5678 commented Feb 20, 2026

Not sure what is going on here, why are all tests failing with this change?

I didn't look into it.

Also, from a design perspective, I don't think it is a good idea to make a public GetLeafRecord dependent on an error listener. That goes against the design of other APIs (e.g.,ModuleDefinition.LookupMember also doesn't depend on the error listener of the underlying reader).

Understood

Besides, if we want improved error messages, why wouldn't we just leave the error handling in the respective GetX initializer methods? Wouldn't that allow for much more fine-grained diagnostics as it is now?

I will abandon this pull request for now. If I come to this pull request, I think I can address your concerns with a source generator for those methods. It seems like an ideal solution to the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement pdb Issues related to AsmResolver.Symbols.Pdb

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants