-
Notifications
You must be signed in to change notification settings - Fork 18
Improve ids pass #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improve ids pass #198
Conversation
|
@nomeata It now does not change ids based on a reserved list of names, since this was pretty Rocq-specific. You will probably have to do some sort of check in your lean translation. |
|
Thanks!
Right, I already have that let render_id a = match a with
| "mut" | "local" | "export" | "import" | "catch" | "syntax"
-> "«" ^ a ^ "»"
| _ -> a |
|
Also will nudge this one to get the pull requests going. Who can review this one? and also #205 :) |
|
This will be easier to review once it uses #212 :-) |
|
Have now adjusted this pass to use #212. Had to add a good amount of custom functions for ids though :) |
This pull request is made to introduce the "improves-ids" pass.
This pass goes through all of the ids and makes sure that there is no ambiguity between names. It also gives names to anonymous constructors using the type name.
Some examples:
to
Based off of #195 so will have to merge that one first.