Skip to content

Feaurization walkthrough #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MikeLippincott
Copy link
Member

@MikeLippincott MikeLippincott commented May 8, 2025

This PR is a walk through of the featurization of the organoids.

The notebook describes the feature space and how many features are extracted for each organoid.

I recommend using ReviewNB for this PR.

@MikeLippincott MikeLippincott requested a review from Copilot May 8, 2025 16:44
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR provides a walkthrough of the featurization process for organoids by updating notebook configurations and refining the file structure and pre-commit configuration.

  • Updates kernel specifications and Python versions in Jupyter notebooks.
  • Refactors argument parsing and formatting in the file structure update notebook.
  • Updates pre-commit hook revisions for consistency and compatibility.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

File Description
0.preprocessing_data/notebooks/1.make_z-stack_images.ipynb Updated kernel display name and adjusted the Python version.
0.preprocessing_data/notebooks/0.update_file_structure.ipynb Reformatted argument parsing and function definitions; adjusted notebook metadata version.
.pre-commit-config.yaml Upgraded revision numbers for pre-commit hooks to the latest tags.
Comments suppressed due to low confidence (2)

.pre-commit-config.yaml:3

  • Verify that updating the revision to v0.7.0 does not introduce any breaking changes in the pre-commit hook behavior, and document if necessary.
rev: v0.7.0

.pre-commit-config.yaml:18

  • Confirm and document that the ruff version update to v0.11.8 is compatible with the current codebase and pre-commit configuration.
rev: v0.11.8

@MikeLippincott MikeLippincott requested a review from axiomcura May 29, 2025 20:11
Copy link
Member

@axiomcura axiomcura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I see that there are some notebooks were updated and added but I don't see any nbconverted scripts

MikeLippincott and others added 6 commits May 29, 2025 15:14
* Initial commit

* inital commit + preprocessing (WayScience#1)

* inital commit

* update paths

* preprocessing

* run on alpine

* change pathing

* HPC

* local update

* addressing comments

* gitignore

* progress catpure

* progress capture

* ingest data

* ingest data

* data ingestion and preprocessing

* data ingestion

* addressing comments
* Initial commit

* inital commit + preprocessing (WayScience#1)

* inital commit

* update paths

* preprocessing

* run on alpine

* change pathing

* HPC

* local update

* addressing comments

* gitignore

* run without the reslicing

* run segmentation:

* ready to run all segmentations for all organoids for one patient

* ready to run all segmentations for all organoids for one patient

* fix the profiling

* fix the texturization feature extraction

* run all organoids segmentation on HPC

* run all organoids segmentation on HPC

* run all organoids segmentation on HPC

* run all organoids segmentation on HPC

* run all organoids segmentation on HPC

* run all organoids segmentation on HPC

* rerun on HPC now that the patient IDs have been added

* rerun on HPC

* data ingestion and preprocessing

* rerun the segs

* rerun the segs

* fixed bash error

* add patient information to scripts

* merge features

* add cleanup

* test with nexflow

* testing nf

* testing nf

* testing nf

* testing nf

* testing nf

* testing nf

* testing nf

* testing nf

* testing nf

* adding nextflow

* adding nextflow

* fix the featurization

* change the profiling

* run on HPC

* rerun the NF0014 featurization

* granularity

* rerun features to get the proper profiling

* update the resource profiling

* prep for featurization

* add the ability to run nf on HPC

* add the ability to run nf on HPC

* run

* rm slurm files

* rm slurm files

* fix nf

* fix nf

* run each

* attempt 2

* attempt 2

* testing on HPC

* add each nextflow change

* push to HPC:

* attempt run on HPC:

* run all

* merge the profiles

* Update 2.segment_images/child_segmentation.sh

Co-authored-by: Copilot <[email protected]>

* Update 1.image_quality_control/scripts/0.cp_image_qc.py

Co-authored-by: Dave Bunten <[email protected]>

* addressing comments

* rebase

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: Dave Bunten <[email protected]>
* Initial commit

* inital commit + preprocessing (WayScience#1)

* inital commit

* update paths

* preprocessing

* run on alpine

* change pathing

* HPC

* local update

* addressing comments

* gitignore

* add segmentation updates

* rerun segmentations

* update segmentations

* addressing comments
* Initial commit

* inital commit + preprocessing (WayScience#1)

* inital commit

* update paths

* preprocessing

* run on alpine

* change pathing

* HPC

* local update

* addressing comments

* gitignore

* preprocessing

* rerun on HPC

* push to HPC

* run all

* run all

* process new patient

* process new patient
@MikeLippincott MikeLippincott merged commit 1247be0 into WayScience:main Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants