fixes #5817
Merged
fixes #5817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example aura for the states:Replace function: |
InfusOnWoW
approved these changes
Apr 11, 2025
emptyrivers
reviewed
Apr 12, 2025
| @@ -43,30 +43,52 @@ local removeAll = function(states) | |||
| return changed | |||
| end | |||
|
|
|||
| local function recurseUpdate(t1, t2) | |||
| local skipKeys = { | |||
There was a problem hiding this comment.
i don't quite understand the point of this?
There was a problem hiding this comment.
It fixes the bug with
function(states, event, updatedTriggerNumber, state)
if event == "TRIGGER" and state then
states:Update("", state[""])
end
endcopying state[""].trigger into states[""].trigger which resulted in WeakAurasOptions replacing the custom trigger view with a copy of the view of an other trigger, cf https://discord.com/channels/172440238717665280/598903823800467496/1360233139452121088
emptyrivers
approved these changes
Apr 12, 2025
new functions: states:Replace(key, newState) works like the Update function but set to nil fields missing in the new table states:Get:(key, field?) returns a state table, or one of it's fields if the parameter "field" is set, returns nil if it doesn't exists bug fixes: recurseUpdate should copy content of new tables instead of it's address don't copy the fields trigger & triggernum into allStates (this needs to be properly addressed)
emptyrivers
approved these changes
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.