Conversation
…nhance linter settings. Update package versions in package.json and pnpm-lock.yaml. Modify GitHub workflow to use stable Biome version. Add new dependencies and update CHANGELOG for version 1.3.0.
WalkthroughThis update upgrades Biome and its related configurations from beta to stable version 2.0.0 across the project, updates dependencies and schema references, and improves documentation formatting for readability. Additionally, pre-commit scripts now support running lefthook via Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Pre-commit Script
participant Mise
participant Devbox
User->>Pre-commit Script: Run lefthook command
Pre-commit Script->>Mise: Try "mise exec -- lefthook -h"
alt Mise available
Pre-commit Script->>Mise: Run "mise exec -- lefthook <args>"
else
Pre-commit Script->>Devbox: Try "devbox run lefthook -h"
alt Devbox available
Pre-commit Script->>Devbox: Run "devbox run lefthook <args>"
else
Pre-commit Script->>User: Print error message
end
end
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
.lefthook/prepare-commit-msg (1)
60-62: Same duplication concern as noted for.lefthook/pre-commitThe
devboxfallback is useful, but the growing cascade ofelifchecks is duplicated across hook scripts. Extracting the resolution logic into a shared helper would improve maintainability.
🧹 Nitpick comments (3)
packages/biome/CHANGELOG.md (1)
3-8: Revise changelog entry for clarity
The entry duplicates the same text as version 1.2.0 ("- update biome to v2"). Consider updating the description to something like "Upgrade Biome to stable v2.0.0 release" for improved clarity and differentiation..lefthook/pre-commit (1)
60-62: Reduce duplication by extracting hook-locator logicThe new
devbox run lefthookbranch works, but each extraelif … lefthook -hline makes the hook scripts harder to maintain (this list now appears in at least two files).
Consider moving the entire lookup chain into a single helper (e.g..lefthook/find_lefthook) that returns the resolved command; each hook could then simply call that helper. This keeps behaviour consistent and future additions require editing one place only..github/workflows/check.yml (1)
26-30: Pin Biome to an explicit minor/patch for deterministic CI
version: 2will always fetch the latest2.xrelease. A future2.1could contain breaking changes that unexpectedly break the workflow.
Prefer an explicit range such as2.0.xor a concrete tag (2.0.0) to keep builds reproducible, and bump deliberately when you’re ready.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (11)
.github/workflows/check.yml(1 hunks).lefthook/pre-commit(1 hunks).lefthook/prepare-commit-msg(1 hunks)biome.json(2 hunks)docs/guides/third-party-integration.md(13 hunks)docs/guides/weaverse-component.md(4 hunks)package.json(1 hunks)packages/biome/CHANGELOG.md(1 hunks)packages/biome/biome.json(1 hunks)packages/biome/package.json(2 hunks)templates/pilot(1 hunks)
🔇 Additional comments (16)
docs/guides/weaverse-component.md (2)
15-15: Approve whitespace enhancement for list separationThe inserted blank line before the Table of Contents list improves visual separation and aligns with our documentation formatting guidelines.
294-294: Approve whitespace enhancement for list separationThe added blank line before the “Component Types” list enhances readability and maintains consistency with other guides.
docs/guides/third-party-integration.md (6)
13-13: Approve blank line before Table of Contents listAdding a blank line here cleanly separates the heading from the list and matches the formatting in other guides.
169-169: Approve import ofcreateSchemain code exampleThe new
import { createSchema } from '@weaverse/hydrogen'line ensures the API widget snippet is accurate and self-contained.
173-173: Approve blank line after imports in snippetThis spacing insertion improves readability between imports and subsequent code in the example.
202-202: Approve blank line before component definitionThe inserted blank line before
const ApiWidget = forwardRef…enhances snippet clarity.
232-232: Approve blank line before export statementThis minor formatting tweak provides better visual delineation in the code block.
265-265: Approve blank line before schema closureAdding space before the closing brace of the schema example keeps consistency with the surrounding code blocks.
templates/pilot (1)
1-1: Verify updated subproject commit referencePlease confirm that
3d62f34dfb51748d7546c74fc4fdd48a558ae9a5corresponds to the intended Biome v2.0.0 stable release in thetemplates/pilotsubmodule.You can run the following script from the repo root to validate:
#!/bin/bash set -e # Initialize and update the submodule git submodule update --init templates/pilot # Check current HEAD of the submodule cd templates/pilot current=$(git rev-parse HEAD) if [ "$current" != "3d62f34dfb51748d7546c74fc4fdd48a558ae9a5" ]; then echo "Mismatch: expected 3d62f34dfb51748d7546c74fc4fdd48a558ae9a5, got $current" >&2 exit 1 fi # Verify the Biome version bump in submodule configuration if ! grep -R '"version": "2.0.0"' .; then echo "Biome version 2.0.0 not found in submodule files" >&2 exit 1 fi echo "Submodule commit and Biome version are correct."package.json (1)
27-27: Upgrade Biome devDependency to stable 2.0.0
This updates@biomejs/biomefrom the beta to the stable release.Please ensure
pnpm-lock.yamlis updated to reflect this dependency change.packages/biome/biome.json (1)
3-3: Update schema URL to stable 2.0.0
The$schemareference has been updated from the beta to the stable schema URL, aligning with the version bump.biome.json (3)
2-2: Enable root configuration
Setting"root": truecorrectly designates this as the root Biome config.
3-3: Switch schema to stable 2.0.0
The schema URL has been updated to the stable 2.0.0 version.
19-20: Add ignore patterns for lockfile and CSS
Ignoringpackage-lock.jsonandapp/styles/app.csshelps avoid unnecessary linting on generated or external files.packages/biome/package.json (2)
3-3: Bump package version to 1.3.0
Version has been correctly incremented to match the changelog entry.
23-23: Upgrade Biome dependency to stable
@biomejs/biomehas been updated to^2.0.0in this package’s dependencies.Verify that the corresponding lockfile has been updated.
1 participant
…nhance linter settings. Update package versions in package.json and pnpm-lock.yaml. Modify GitHub workflow to use stable Biome version. Add new dependencies and update CHANGELOG for version 1.3.0.
Summary by CodeRabbit