jaf mandatory value changes#460
Merged
Merged
Conversation
Co-authored-by: Pranay-Gottimukula <97828875+Pranay-Gottimukula@users.noreply.github.com> Co-authored-by: metamyte <89248467+metamyteee@users.noreply.github.com> Co-authored-by: Sakshya2504 <singhkaserasakshya2504@gmail.com>
Co-authored-by: Pranay-Gottimukula <97828875+Pranay-Gottimukula@users.noreply.github.com> Co-authored-by: metamyte <89248467+metamyteee@users.noreply.github.com> Co-authored-by: Sakshya2504 <singhkaserasakshya2504@gmail.com>
Co-authored-by: Pranay-Gottimukula <97828875+Pranay-Gottimukula@users.noreply.github.com> Co-authored-by: metamyte <89248467+metamyteee@users.noreply.github.com> Co-authored-by: Sakshya2504 <singhkaserasakshya2504@gmail.com> Co-authored-by: Anand Vivek <anand1234.vivek@gmail.com>
mittal-ishaan
approved these changes
Jul 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts JAF job details to make certain previously-mandatory fields optional, updates related UI indicators, and tweaks recruiter job detail editing safety around optional nested selectionProcedure data.
Changes:
- Relax validation/UI “required” behavior for
locationandselectionMode. - Add minor UI copy changes (labels + helper hint).
- Add optional chaining in recruiter job detail page selection procedure editing.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/validation/jaf.validation.ts | Makes location and selectionMode optional in Yup schema (with updated allowed values). |
| src/components/JAF/TermsAndConditions.js | Updates a hard-coded internship PPO status deadline date. |
| src/components/JAF/JobDetails.tsx | Removes required UI markers for fields and adds/updates user-facing text. |
| src/app/(routes)/recruiter/jobs/[jobID]/page.tsx | Adds optional chaining around selectionProcedure reads/updates in edit flows. |
Files not reviewed (1)
- src/components/JAF/TermsAndConditions.js: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
157
to
160
| location: Yup.string() | ||
| .required("Job location is required") | ||
| .optional() | ||
| .min(2, "Location must be at least 2 characters") | ||
| .max(200, "Location must not exceed 200 characters"), |
Comment on lines
250
to
253
| selectionMode: Yup.string() | ||
| .oneOf( | ||
| Object.values(SelectionModeEnum), | ||
| "Please select a valid selection mode", | ||
| ) | ||
| .required("Selection mode is required"), | ||
| .optional() | ||
| .oneOf([...Object.values(SelectionModeEnum), ""], "Please select a valid selection mode"), | ||
|
|
Comment on lines
833
to
835
| <Text strong className="text-xs md:text-sm text-gray-700"> | ||
| Internship Duration | ||
| Internship Duration(In Month) | ||
| </Text> |
Comment on lines
+1356
to
+1360
| marginTop: 4, | ||
| fontStyle: "bold", | ||
| }} | ||
| > | ||
| please select relevant branches/Specialization from the below drop-down |
Comment on lines
105
to
108
| selectionProcedure: { | ||
| ...prev.selectionProcedure, | ||
| tests: prev.selectionProcedure.tests.filter((_, i) => i !== index), | ||
| tests: prev.selectionProcedure?.tests.filter((_, i) => i !== index), | ||
| }, |
Comment on lines
129
to
134
| selectionProcedure: { | ||
| ...prev.selectionProcedure, | ||
| interviews: prev.selectionProcedure.interviews.filter( | ||
| interviews: prev.selectionProcedure?.interviews.filter( | ||
| (_, i) => i !== index, | ||
| ), | ||
| }, |
|
|
||
| let colors = | ||
| "text-green-400 text-red-400 text-indigo-400 text-gray-400 text-blue-400 text-purple-400"; | ||
| "text-green-400 text-red-400 text-indigo-400 text-gray-400 text-blue-400 text-purple-400 text-yellow-400"; |
| <React.Fragment> | ||
| <p className="text-white font-bold ">Label</p> | ||
| {Array.from(labelsClasses.entries()).map(([label, color], idx) => { | ||
| {Array.from(labelsClasses.entries()).map(([label, colors], idx) => { |
| color: "#9ca3af", | ||
| display: "block", | ||
| marginTop: 4, | ||
| fontStyle: "bold", |
| }} | ||
| > | ||
| <Text strong className="text-xs md:text-sm text-gray-700"> | ||
| Is there a bond requirement? |
Comment on lines
+108
to
+125
| const payload = data | ||
| .map((row) => { | ||
| const student = students.find( | ||
| (s) => String(s.rollNo) === String(row.rollNo), | ||
| ); | ||
|
|
||
| if (!student) return null; | ||
|
|
||
| return { | ||
| id: student.id, | ||
| cpi: Number(row.cpi), | ||
| }; | ||
| }) | ||
| .filter(Boolean); | ||
| if (payload.length === 0) { | ||
| toast.error("No matching roll numbers found"); | ||
| return; | ||
| } |
Comment on lines
+82
to
+87
| export async function updateStudents(payload: any[]): Promise<any> { | ||
| return apiCall("/students", { | ||
| method: "PATCH", | ||
| body: payload, | ||
| }); | ||
| } |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
👷 Deploy request for tpc-portal-develop pending review.Visit the deploys page to approve it
|
Princekumarofficial
added a commit
that referenced
this pull request
Jul 13, 2026
Co-authored-by: Prince Kumar <x.prince.x@outlook.com> Co-authored-by: Pranay-Gottimukula <97828875+Pranay-Gottimukula@users.noreply.github.com> Co-authored-by: Sakshya2504 <singhkaserasakshya2504@gmail.com> Co-authored-by: Anand Vivek <anand1234.vivek@gmail.com> Co-authored-by: Prince Kumar <ep230051013@iiti.ac.in> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.