docs: add authorization note to create_pool()

[cyb3ralee]

Closes #1119

What This Does

Adds documentation to create_pool() explaining that it does not require the creator address to authorize the call.

The Issue

• create_pool() does NOT call creator.require_auth()
• create_pool_for_school() DOES call creator.require_auth() before delegating to create_pool()
• This inconsistency was not documented anywhere

The Fix

Added # Authorization section to create_pool() doc comment:

• Clarifies that any address can call it "as" any other creator
• References create_pool_for_school for the authorized version
• Explains that creator.require_auth() is never called

Before

/// Create a new donation / sponsorship pool.
pub fn create_pool(
    env: Env,
    creator: Address,
    title: String,
    description: String,
    goal: u128,
    application_deadline: u64,
) -> u32 {

After

/// Create a new donation / sponsorship pool.
///
/// # Authorization
/// This function does **not** require the `creator` address to authorize the
/// call (`creator.require_auth()` is never called). Any address can create
/// a pool "as" any other address. For authorization, use
/// [`create_pool_for_school`] which validates that the caller is authorized.
pub fn create_pool(
    env: Env,
    creator: Address,
    title: String,
    description: String,
    goal: u128,
    application_deadline: u64,
) -> u32 {

Files Changed

• nevo_contract/contracts/hello-world/src/lib.rs

Acceptance Criteria

• Documentation note added to create_pool()
• cargo test --lib passes (pre-existing errors not related to this change)

[drips-wave]

@smartalee Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits