[NFC] Improve wasm-reduce help text #7293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osa1
reviewed
Feb 14, 2025
| Whatever the command does, we will preserve as we copy progressively smaller | ||
| files to t.wasm. As we make progress, the smallest file will be written to | ||
| the working file, w.wasm, and when reduction is done you will find the final | ||
| result there. |
There was a problem hiding this comment.
Maybe I'm doing it wrong, but when I run the example command above, I see a t.wasm generated but no w.wasm.
The full output of the run:
|wasm-reduce
|input: <snip>
|test: t.wasm
|working: w.wasm
|bin dir: <snip>
|extra flags: -all
|expected result:
[ProgramResult] code: 0 stdout:
[====]
in 0.092609 seconds
[/ProgramResult]
|!! Make sure the above is what you expect! !!
|checking that command has different behavior on different inputs (this verifies that the test file is used by the command)
|checking that command has expected behavior on canonicalized (read-written) binary
|! failed to read and write the binary
[ProgramResult] code: 31744 stdout:
[====]
in 2.03463 seconds
[/ProgramResult]
Fatal: |! stopping, as it is very unlikely reduction can succeed (use -f to ignore this check)
There was a problem hiding this comment.
(discussed offline, but for others reading, my suggestions were --timeout=10 and/or --text, and if neither works, to send me the file to investigate)
Co-authored-by: Ömer Sinan Ağacan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.