Skip to content

add asyncify_get_state #8065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add asyncify_get_state #8065

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b116d81
add asyncify_get_state
andrewmd5 Nov 22, 2025
1c59a1c
fix fallthrough
andrewmd5 Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/passes/Asyncify.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,7 @@ static const Name START_UNWIND = "start_unwind";
static const Name STOP_UNWIND = "stop_unwind";
static const Name START_REWIND = "start_rewind";
static const Name STOP_REWIND = "stop_rewind";
static const Name GET_STATE = "get_state";
static const Name ASYNCIFY_GET_CALL_INDEX = "__asyncify_get_call_index";
static const Name ASYNCIFY_CHECK_CALL_INDEX = "__asyncify_check_call_index";

Expand Down Expand Up @@ -582,6 +583,8 @@ class ModuleAnalyzer {
renamings[func->name] = ASYNCIFY_START_REWIND;
} else if (func->base == STOP_REWIND) {
renamings[func->name] = ASYNCIFY_STOP_REWIND;
} else if (func->base == GET_STATE) {
renamings[func->name] = ASYNCIFY_GET_STATE;
} else {
Fatal() << "call to unidenfied asyncify import: " << func->base;
}
Expand Down Expand Up @@ -637,6 +640,8 @@ class ModuleAnalyzer {
} else if (target->base == STOP_REWIND) {
info.canChangeState = true;
info.isTopMostRuntime = true;
} else if (target->base == GET_STATE) {
info.canChangeState = false;
Copy link
Member

@kripken kripken Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is wrong - it will undo a previous true, forgetting that another call can change the state.

That is, these flags start as false, and should only ever change to true.

Copy link
Author

@andrewmd5 andrewmd5 Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense; this branch is necessary though to prevent falling through to the unreachable, so I’ll add a condition to the outer scope.

} else {
WASM_UNREACHABLE("call to unidenfied asyncify import");
}
Expand Down
Loading