Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make close-{readable,writable} symmetric in taking an optional error-context #446

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lukewagner
Copy link
Member

The 0.3 updates to wasi:http in wasi-http/#143 helped highlight the fact that the reasoning for why we want to be able to pass an error-context into stream.close-readable and get an error-context out of stream.read applies just as well in the opposite direction (to stream.close-writable and stream.write, resp.). This PR basically just removes one of the few asymmetries from the otherwise-quite-symmetric read/write code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant