Syntax and validation for descriptor casts - #105
Open
tlively wants to merge 3 commits into
Open
Conversation
tlively
commented
Jul 13, 2026
Member
Author
|
The conclusion of the validation rules for the new branch instructions are slightly too wide when rendered. Is there anything we can do about that? |
rossberg
approved these changes
Jul 22, 2026
rossberg
left a comment
rossberg
left a comment
Member
There was a problem hiding this comment.
The renderer should respect line breaks inside sequences, but probably doesn't recognise them around infix operators atm.
But given that both these rule repeat a longish ref type between immediate and instruction type, it may make sense to name that one and pattern-match it with an if-premise, which probably solves the problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.