Use module definition instead of assert_unlinkable hack - #60
Merged
Conversation
We previously used linking errors as a hack to avoid actually allocating memories of the maximum representable size in these tests, but it turns out that `(module definition ...)` validates but does not instantiate a module, which is exactly what we need here.
rossberg
approved these changes
Jun 15, 2026
Collaborator
Author
|
CI seems broken, something to do with downloading ocaml tools. Unrelated to this PR, so I'll go ahead and merge. |
Member
|
The YAML file in this repo looks outdated. Syncing with upstream should fix the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously used linking errors as a hack to avoid actually allocating memories of the maximum representable size in these tests, but it turns out that
(module definition ...)validates but does not instantiate a module, which is exactly what we need here.@rossberg PTAL