ESM Phase Imports import() & new Worker() support for WA.Module #106
+60
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the ESM Phase Imports proposal, which in turn allows Wasm to define support for
new Worker(module)andimport(module)wheremoduleis an instance ofWebAssembly.Module.The corresponding HTML integration PR is available in whatwg/html#11152.
We carefully define the difference between rooted and unrooted modules (those checked in the registry by the source phase, and those that are dynamically compiled with user sources / "evalish"), and then we define registry identity and include the URL in the transfer process for rooted modules.
Registry identity in the ESM Phase Imports proposal is based on the
ModuleSourcesEqualconcrete method which is implemented for WebAssembly Module Record allowingimport(module) === import(module)equality for rooted sources and through structured clone transfer. For more info, this topic has been covered extensively in the last TC39 meetings for the ESM Phase Imports proposal.