Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Fix js-api tests #87

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Fix js-api tests #87

merged 1 commit into from
Oct 7, 2024

Conversation

backes
Copy link
Member

@backes backes commented Oct 4, 2024

This fixes four things in the JS-API tests:

  1. Pass BigInt for i64 WebAssembly.Table and WebAssembly.Memory constructors.
  2. Use reference types for tables (would throw a TypeError otherwise).
  3. Overwrite 'toString' instead of 'valueOf' for the 'index' property which is a string.
  4. 'index' is read after 'element' and before 'initial' in Table construction.

This fixes four things in the JS-API tests:
1. Pass BigInt for i64 WebAssembly.Table and WebAssembly.Memory
   constructors.
2. Use reference types for tables (would throw a TypeError
   otherwise).
3. Overwrite 'toString' instead of 'valueOf' for the 'index' property
   which is a string.
4. 'index' is read after 'element' and before 'initial' in Table
   construction.
@sbc100 sbc100 merged commit 2e89dc5 into WebAssembly:main Oct 7, 2024
1 check passed
@backes backes deleted the fix-js-api-tests branch October 8, 2024 08:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants