This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Fix js-api tests #87
Merged
Fix js-api tests #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes four things in the JS-API tests: 1. Pass BigInt for i64 WebAssembly.Table and WebAssembly.Memory constructors. 2. Use reference types for tables (would throw a TypeError otherwise). 3. Overwrite 'toString' instead of 'valueOf' for the 'index' property which is a string. 4. 'index' is read after 'element' and before 'initial' in Table construction.
sbc100
approved these changes
Oct 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes four things in the JS-API tests: