Translating thread and wait to js and test harness for multi-threaded programs #229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #218 and supersedes #219.
It includes changes in the following aspects:
test/harness/testharness*
) to newer versions from the upstream WPT repo. This is required because it fixes several problems aroundfetch_tests_from_workers
and tests getting stuck (which also affects the upstreamWebAssembly/spec
repo).Either
expected results.thread
andwait
constructs in wast scripts.test/harness/async_*
) to work with multi-threaded test cases. It includes the JS file names under test in the test reporting, because otherwise the test harness will complain about duplicate test names coming from different threads.WebAssembly/spec
repo (main
branch). For instance, in theassert_unlinkable
function, it does not wait for the preceding updates to the registry to happen. It will non-deterministically produce wrong test results (false negatives and false positives) depending on the timing and order of the tests.test/build.py
) with additional flags. (In the upstreamWebAssembly/spec
repo, it generates some JS file in the wrong paths, resulting in non-existent files when running the testsuite; but this behaviours is not present in this branch of this repo.)