Skip to content

Conversation

@SoniEx2
Copy link
Collaborator

@SoniEx2 SoniEx2 commented Oct 5, 2024

oops 😅 (local decl count != local count)

@SoniEx2
Copy link
Collaborator Author

SoniEx2 commented Oct 7, 2024

@sbc100

(tag $e0)
(func (export "test") (result i32)
(local $a i32)
(local $b i32)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just update an existing test instead maybe ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like so?

Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

@sbc100 sbc100 merged commit e1d84ff into WebAssembly:main Oct 7, 2024
18 checks passed
@SoniEx2 SoniEx2 deleted the fix-interp-properly branch October 7, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants