Skip to content

Conversation

@SoniEx2
Copy link
Collaborator

@SoniEx2 SoniEx2 commented Oct 8, 2024

No description provided.

Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No test output changed as the result of this? Would writing a test for this be tricky?

I don't really know this code myself but the change looks reasonable.

@SoniEx2
Copy link
Collaborator Author

SoniEx2 commented Oct 8, 2024

yeah upstream doesn't have tests for this.

uh hmm... we're not sure how to trigger this, maybe something like

throw
try
catch
end

?

@SoniEx2
Copy link
Collaborator Author

SoniEx2 commented Oct 8, 2024

(yep:

  +out/test/regress/interp-throw-before-try.txt:15: expected an exception to be thrown
  +1/2 tests passed.

)

@SoniEx2
Copy link
Collaborator Author

SoniEx2 commented Oct 8, 2024

@sbc100

@sbc100 sbc100 merged commit 7fdccf7 into WebAssembly:main Oct 8, 2024
18 checks passed
@SoniEx2 SoniEx2 deleted the interp-try-off-by-one branch October 8, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants