Skip to content

Fix two resource leak bugs (wasip2) #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

Fix two resource leak bugs (wasip2) #635

merged 1 commit into from
Oct 16, 2025

Conversation

@catamorphism
Copy link
Collaborator

@catamorphism catamorphism commented Oct 14, 2025

  • scandir() wasn't closing its file descriptors
  • The remove_and_drop_directory_stream() function that's used in a few places was deleting the file descriptor from the table so that the underlying file handle wouldn't be closed

@catamorphism
Fix two resource leak bugs
a7244e9 
* scandir() wasn't closing its file descriptors
* The remove_and_drop_directory_stream() function that's used in a
few places was deleting the file descriptor from the table so that
the underlying file handle wouldn't be closed
@catamorphism catamorphism requested a review from pchickey October 14, 2025 01:33
@catamorphism catamorphism merged commit 25827cc into WebAssembly:main Oct 16, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pchickey pchickey pchickey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@catamorphism @pchickey