Add sockets tests for hangups on both sides, and implement timeouts for TCP sockets #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchickey
approved these changes
Oct 16, 2025
…or TCP sockets The new tests are based on the previous simple test where the server accepts one connection and echoes back a message received from the client. Scenarios tested: * Client hangs up after connecting * Client hangs up while sending * Client hangs up after sending * Client hangs up while receiving * Server hangs up after connecting but before receiving data from client * Server hangs up while receiving data * Server hangs up after receiving all data but before sending data back to client * Server hangs up while sending data back to client As part of this testing, I implemented timeouts for TCP sockets. There are no tests for UDP sockets yet, so timeouts are not implemented yet for them.
catamorphism
force-pushed
the
sockets-testing-hangups
branch
from
8ec291a to
b7540c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new tests are based on the previous simple test where the server accepts one connection and echoes back a message received from the client.
Scenarios tested:
As part of this testing, I implemented timeouts for TCP sockets. There are no tests for UDP sockets yet, so timeouts are not implemented yet for them.