Skip to content

Set CMAKE_C_COMPILER_WORKS globally #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yamt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Set CMAKE_C_COMPILER_WORKS globally #713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
clang_version: 15.0.7
llvm_asset_suffix: arm64-apple-darwin22.0
upload: macos-clang-15
args: -DBUILD_SHARED=OFF -DCMAKE_C_COMPILER_WORKS=ON
args: -DBUILD_SHARED=OFF
- name: Build on Windows x86_64
os: windows-2025
clang_version: 20.1.8
Expand Down
5 changes: 5 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ endif()
# Force a cross-compile to WASI at all times.
set(CMAKE_SYSTEM_NAME WASI)

# Skip the compiler check.
# We usually don't set CMAKE_C_COMPILER_TARGET correctly. Even if we do,
# the check requires more than what we actually require. (eg. crt objects)
set(CMAKE_C_COMPILER_WORKS 1)

# I'm not entirely sure why this is necessary on Windows. This may be a bug in
# CMake, I'm not sure. The problem is that, at least on CI, CMake detects that
# the compiler in use is clang but doesn't understand the `SYSTEM` header
Expand Down