Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename 'runtime' interface name to 'store' #14

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

Mossaka
Copy link
Collaborator

@Mossaka Mossaka commented Sep 11, 2024

It renames:

runtime -> store
config-error -> error

and

delete the hand-written config.md in preference of the generated imports.md doc. Closes #13

question: I remember we briefly discussed this but I forgot about the rationals behind the subtle difference between the proposal name "wasi-runtime-config" and the actual WIT package name "wasi:config", what are the reasons? Could we rename this repo to "wasi-config" but keeps runtime configuration as an option in the README? @thomastaylor312 @lukewagner

Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>
@lukewagner
Copy link
Member

Thanks! To your question: originally, there was a sketch to use value imports to import configuration values, with 1 value import per individual configuration value, allowing the names of required configuration values to be known declaratively, allowing various DX/security/perf improvements. But that was a much bigger lift (for the tooling and runtime), so we instead prioritized adding a more-dynamic (runtime) configuration interface (which we'd need in any case, since sometimes you just don't know AOT what configuration you need), hence the name of the repo. Whatever the history, renaming the repo to wasi-config to match wasi:config makes sense to me. Eventually, I'd like to return to the declarative value-import approach, we could just add that to this same repo (alongside wasi:config/store).

Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>
Copy link
Collaborator

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just words, no code

imports.md Outdated Show resolved Hide resolved
imports.md Outdated Show resolved Hide resolved
imports.md Outdated Show resolved Hide resolved
wit/store.wit Outdated Show resolved Hide resolved
Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>
Copy link
Collaborator

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving upon my suggestions. LGTM!

@Mossaka
Copy link
Collaborator Author

Mossaka commented Sep 13, 2024

Could you please take a look? @thomastaylor312

@thomastaylor312
Copy link
Collaborator

And I am all good with a repo rename

@Mossaka Mossaka merged commit f4d699b into WebAssembly:main Sep 24, 2024
1 check passed
@Mossaka Mossaka deleted the rename-to-store branch September 24, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider renaming the 'runtime' interface to 'store' for consistency with other WASI proposals
4 participants