-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin CI runner images to explicit versions #507
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8e24cc6
Pin CI runner images to explicit versions
alexcrichton c098a7e
Try not custom-installing clang 18
alexcrichton fac487b
Try to fix CI issue
alexcrichton 7c0c3a5
Fix CI again (attempt)
alexcrichton 4cbcce3
Further try to fix CI
alexcrichton 2c49440
Another fix for CI
alexcrichton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,10 +19,10 @@ jobs: | |
matrix: | ||
include: | ||
- artifact: x86_64-linux | ||
os: ubuntu-latest | ||
os: ubuntu-24.04 | ||
|
||
- artifact: arm64-linux | ||
os: ubuntu-latest | ||
os: ubuntu-24.04 | ||
rust_target: aarch64-unknown-linux-gnu | ||
env: | ||
# Don't build a sysroot for this cross-compiled target since it | ||
|
@@ -41,15 +41,15 @@ jobs: | |
-DRUST_TARGET=aarch64-unknown-linux-gnu | ||
|
||
- artifact: arm64-macos | ||
os: macos-latest | ||
os: macos-14 | ||
rust_target: aarch64-apple-darwin | ||
env: | ||
WASI_SDK_CI_TOOLCHAIN_LLVM_CMAKE_ARGS: >- | ||
-DCMAKE_OSX_DEPLOYMENT_TARGET=10.12 | ||
-DCMAKE_OSX_ARCHITECTURES=arm64 | ||
|
||
- artifact: x86_64-macos | ||
os: macos-latest | ||
os: macos-14 | ||
rust_target: x86_64-apple-darwin | ||
env: | ||
WASI_SDK_CI_SKIP_SYSROOT: 1 | ||
|
@@ -58,7 +58,7 @@ jobs: | |
-DCMAKE_OSX_ARCHITECTURES=x86_64 | ||
|
||
- artifact: x86_64-windows | ||
os: windows-latest | ||
os: windows-2022 | ||
|
||
env: ${{ matrix.env || fromJSON('{}') }} | ||
steps: | ||
|
@@ -165,25 +165,21 @@ jobs: | |
|
||
build-only-sysroot: | ||
name: Build only sysroot | ||
runs-on: ubuntu-22.04 | ||
runs-on: ubuntu-24.04 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 | ||
- uses: ./.github/actions/checkout | ||
- uses: ./.github/actions/install-deps | ||
- run: | | ||
wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add - | ||
name=$(lsb_release -s -c) | ||
sudo add-apt-repository -y "deb http://apt.llvm.org/$name/ llvm-toolchain-$name-18 main" | ||
sudo add-apt-repository -y "deb-src http://apt.llvm.org/$name/ llvm-toolchain-$name-18 main" | ||
sudo apt-get install -y clang-18 llvm-18 lld-18 | ||
- run: cargo install [email protected] | ||
- run: cargo install [email protected] | ||
- run: | | ||
cmake -G Ninja -B build -S . \ | ||
-DCMAKE_C_COMPILER=/usr/lib/llvm-18/bin/clang \ | ||
-DCMAKE_SYSTEM_NAME=WASI \ | ||
-DWASI_SDK_INCLUDE_TESTS=ON | ||
-DWASI_SDK_INCLUDE_TESTS=ON \ | ||
-DCMAKE_C_LINKER_DEPFILE_SUPPORTED=OFF \ | ||
-DCMAKE_CXX_LINKER_DEPFILE_SUPPORTED=OFF | ||
- run: ninja -C build | ||
- run: ctest --output-on-failure --parallel 10 --test-dir build/tests | ||
|
||
|
@@ -193,7 +189,7 @@ jobs: | |
finalize: | ||
name: Finalize wasi-sdk artifacts | ||
needs: build | ||
runs-on: ubuntu-latest | ||
runs-on: ubuntu-24.04 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
|
@@ -253,7 +249,7 @@ jobs: | |
test-standalone: | ||
name: Test standalone toolchain | ||
needs: build | ||
runs-on: ubuntu-latest | ||
runs-on: ubuntu-24.04 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is need here and below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I believe so yeah. This layer is for the cmake build of wasi-sdk itself, aka when building tests. The cmake layer is then for the sub-cmake-builds of libraries like libcxx themselves. At least from CI it looked like both were necessary to get things passing when just using "clang" as the compiler.