Attempt to fix finding libedit on macOS#609
Conversation
First pass at trying to fix this...
| ProcessorCount(nproc) | ||
| find_program(MAKE_EXECUTABLE make REQUIRED) | ||
| if(CMAKE_SYSTEM_NAME STREQUAL Darwin) | ||
| set(libedit_ldflags -Wl,-install_name,@rpath/libedit.0.dylib) |
There was a problem hiding this comment.
Do we set the rpath to ../lib somewhere (or does CMake do that automatically)? Or should this be @rpath/../lib/libedit.0.dylib?
There was a problem hiding this comment.
Eh this doesn't even work as-is given CI (and more local testing), so I'm still flailing trying to figure this out
There was a problem hiding this comment.
My current thinking is: no, but that's only because the -install_name for libLLVM.dylib is @rpath/libLLVM.dylib. My ill-informed rationale is that the executable is responsible for saying what it's rpath is, and then the libraries linked say "ok sure and now you find me in the rpath"
|
I can confirm that the artifact from CI on the current state of this branch works for me: downloading |
3 participants
First pass at trying to fix this...