p3(http): Assert request get-{authority,scheme} - #272
Merged
Conversation
This commit tests the presence of the authority and scheme in the inbound http request. The presence/absence of these fields in the inbound request is currently not finalized in the spec[1], hence why this test is expected to fail. [1]: WebAssembly/WASI#788
andreiltd
approved these changes
Jul 15, 2026
Collaborator
Author
|
I will note, for posterity, that p2, at least in Wasmtime, does derive the authority/scheme from the host, see bytecodealliance/wasmtime#8923 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit tests the presence of the authority and scheme in the inbound http request.
The presence/absence of these fields in the inbound request is currently not finalized in the spec1, hence why this test is expected to fail.