Update jco to 1.26.1 - #275
Open
saulecabrera wants to merge 3 commits into
Open
Conversation
This unblocks WebAssembly#274
Collaborator
Author
|
It seems that the entry for the jco binary changed between versions. |
Collaborator
|
Yeah, I think this is because jco is now TS, so actual entry is compiled. I think changing @@ -75,7 +75,7 @@ def _jco_runtime_command_impl(ctx: AnalysisContext) -> list[Provider]:
jco_workspace = ctx.attrs.jco[DefaultInfo].default_outputs[0]
jco_js = cmd_args(
jco_workspace,
- format = "{}/node_modules/@bytecodealliance/jco/src/jco.js",
+ format = "{}/node_modules/@bytecodealliance/jco/dist/jco.js",
) |
Collaborator
|
And also: @@ -5,7 +5,7 @@ load("@wasmono//toolchains/wasm:node.bzl", "NodeInfo")
load("@wasmono//:defs.bzl", "host_arch", "host_os")
load(":releases.bzl", "WAMR_RELEASES", "WASMEDGE_RELEASES", "WASMTIME_RELEASES", "WAZERO_RELEASES")
-DEFAULT_JCO_VERSION = "1.24.1"
+DEFAULT_JCO_VERSION = "1.26.1" |
Collaborator
Author
|
Updating the binary paths fixed the main issue, there is one failure though, which seems totally unrelated to the binary paths https://github.com/WebAssembly/wasi-testsuite/actions/runs/30288891239/job/90053467311?pr=275 |
Collaborator
That looks like legitimate regression 🤔 |
Collaborator
Author
|
I am no expert on jco, however, doing a small bisection, I think the issue is probably with With:
I think that in both versions the |
Collaborator
Author
|
I have opened bytecodealliance/jco#1787 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unblocks #274