Skip to content

Update jco to 1.26.1 - #275

Open
saulecabrera wants to merge 3 commits into
WebAssembly:mainfrom
saulecabrera:update-jco-1261
Open

Update jco to 1.26.1#275
saulecabrera wants to merge 3 commits into
WebAssembly:mainfrom
saulecabrera:update-jco-1261

Conversation

@saulecabrera

Copy link
Copy Markdown
Collaborator

This unblocks #274

@saulecabrera
saulecabrera requested a review from andreiltd as a code owner July 27, 2026 16:39
@saulecabrera

Copy link
Copy Markdown
Collaborator Author

It seems that the entry for the jco binary changed between versions.

@andreiltd

Copy link
Copy Markdown
Collaborator

Yeah, I think this is because jco is now TS, so actual entry is compiled. I think changing src/ to dist/ should work:

@@ -75,7 +75,7 @@ def _jco_runtime_command_impl(ctx: AnalysisContext) -> list[Provider]:
     jco_workspace = ctx.attrs.jco[DefaultInfo].default_outputs[0]
     jco_js = cmd_args(
         jco_workspace,
-        format = "{}/node_modules/@bytecodealliance/jco/src/jco.js",
+        format = "{}/node_modules/@bytecodealliance/jco/dist/jco.js",
     )

@andreiltd

Copy link
Copy Markdown
Collaborator

And also:

@@ -5,7 +5,7 @@ load("@wasmono//toolchains/wasm:node.bzl", "NodeInfo")
 load("@wasmono//:defs.bzl", "host_arch", "host_os")
 load(":releases.bzl", "WAMR_RELEASES", "WASMEDGE_RELEASES", "WASMTIME_RELEASES", "WAZERO_RELEASES")
 
-DEFAULT_JCO_VERSION = "1.24.1"
+DEFAULT_JCO_VERSION = "1.26.1"

@saulecabrera

Copy link
Copy Markdown
Collaborator Author

Updating the binary paths fixed the main issue, there is one failure though, which seems totally unrelated to the binary paths https://github.com/WebAssembly/wasi-testsuite/actions/runs/30288891239/job/90053467311?pr=275

@andreiltd

Copy link
Copy Markdown
Collaborator
✗ root//tests/rust/wasm32-wasip3:filesystem-io_jco

That looks like legitimate regression 🤔

@saulecabrera

saulecabrera commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

I am no expert on jco, however, doing a small bisection, I think the issue is probably with jco-transpile:

With:

  • jco-v1.25.2 the test passes
  • jco-v1.26.0 the test fails

I think that in both versions the p3-shim is identical, the only thing that differs is jco-transpile, updated from v0.4.2 -> v0.5.x.

@saulecabrera

Copy link
Copy Markdown
Collaborator Author

I have opened bytecodealliance/jco#1787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants