Skip to content

C API: u8 in Rust corresponds to unsigned char* in C#179

Open
dannywillems wants to merge 1 commit intoWebAssembly:mainfrom
dannywillems:dannywillems@fix-wrong-c-api
Open

C API: u8 in Rust corresponds to unsigned char* in C#179
dannywillems wants to merge 1 commit intoWebAssembly:mainfrom
dannywillems:dannywillems@fix-wrong-c-api

Conversation

@dannywillems
Copy link

@rossberg
Copy link
Member

Wouldn't it be more appropriate to fix the typedef for byte_t instead?

@dannywillems
Copy link
Author

I thought about it. byte_t is used in different places, and I didn't know if it would impact a lot of the codebase/users.

If you confirm it is fine, I agree with changing.

@syrusakbary
Copy link
Contributor

@rossberg thoughts on this 👆?

@rossberg
Copy link
Member

Yes, confirmed. Thanks. :)

@syrusakbary
Copy link
Contributor

@dannywillems should we update then the byte_t typedef so this PR can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants