Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This small PR adds a
sharedfield to thewasm_limits_ttype. This change, seems to be the only top-level left change needed to support the threading proposal. I also opened a CL with the same objective to V8, using the patchedwasm.handwasm.hhheaders from this PR.This PR also fixes the tests to adapt the current semantics to the change (i.e. adding
falsewhen instantiating awasm_limits_tin C).The PR currently does not test the behaviour of the API with respect to the threading proposal. To this end, I wait for your feedback on which specific tests would be better to implement, if any.