Skip to content

Marking interfaces as [SecureContext] #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2018
Merged

Marking interfaces as [SecureContext] #192

merged 2 commits into from
Oct 17, 2018

Conversation

cwilso
Copy link
Contributor

@cwilso cwilso commented Oct 16, 2018

Fixes issue #183.

@cwilso cwilso added this to the V1 milestone Oct 16, 2018
@cwilso cwilso self-assigned this Oct 16, 2018
@cwilso cwilso requested a review from marcoscaceres October 16, 2018 10:19
marcoscaceres
marcoscaceres suggested changes Oct 16, 2018
View reviewed changes
Copy link
Contributor

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing.

marcoscaceres
marcoscaceres suggested changes Oct 16, 2018
View reviewed changes
Copy link
Contributor

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of other nits.

@cwilso cwilso merged commit 05de4f0 into WebAudio:gh-pages Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres requested changes

Assignees

@cwilso cwilso

Labels
None yet
Projects
None yet
Milestone
CR
Development

Successfully merging this pull request may close these issues.
2 participants
@cwilso @marcoscaceres