Skip to content

Update explainer with TAG feedback #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

evanbliu
Copy link
Collaborator

This PR updates the explainer with TAG feedback: w3ctag/design-reviews#1038 (comment)

@evanbliu evanbliu requested review from padenot and hoch April 29, 2025 17:35
Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit (a typo)

### 2. `Promise<boolean> installOnDevice()`
This method install the resources required for on-device speech recognition. The installation process may download and configure necessary language models.
### 2. `Promise<boolean> installOnDevice(DOMString[] lang)`
This method install the resources required for on-device speech recognition for the given BCP-47 language codes. The installation process may download and configure necessary language models.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

install -> installs

@evanbliu evanbliu merged commit af3de99 into WebAudio:main Apr 29, 2025
1 check passed
github-actions bot added a commit to evanbliu/speech-api that referenced this pull request Apr 29, 2025
SHA: af3de99
Reason: push, by evanbliu

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants