Skip to content

Cards 5, 6, 9, 11, 18, 20, 21, 27, 42, 43, 44, "mobile content block" #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: feature/WDSBT-241-Design-System-Cards
Choose a base branch
from
Open

Cards 5, 6, 9, 11, 18, 20, 21, 27, 42, 43, 44, "mobile content block" #59

wants to merge 27 commits into from

Conversation

lepittenger
Copy link
Member

@lepittenger lepittenger commented Apr 23, 2025 •
edited
Loading

Closes

Link to test

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

image

image

Added to documentation?

  • 📜 README.md
  • 📓 Confluence
  • 🙅 No documentation needed

Added tests?

  • 👍 Yes
  • 🙅 No, because they aren't needed
  • 🙋 No, because I need help

Testing Instructions

Reviewer's Testing Checklist

As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.

  • Visual Regression Testing: Ensure that existing functionality is not negatively impacted by the changes.
  • Cross-Browser Compatibility: Test on major browsers (Chrome, Firefox, Safari) to ensure compatibility.
  • Mobile Responsiveness: Confirm that the changes are responsive and functional on various mobile devices.
  • Theme Compatibility: Ensure that the changes do not adversely affect the site's theme and styling.
  • Linting: Check that the code passes all linting checks (PHPCS, ESLint, SassLint). Check if PR passes code quality check.
  • Accessibility Testing: Validate that the changes comply with accessibility standards. Run npm run a11y.
  • Security Best Practices: Ensure that the code follows WordPress security best practices. Check if PR passes security check.
  • Documentation: Ensure that any new features or changes are appropriately documented in the README.md or Confluence.
  • Post-Deployment Tasks: Check if there are any tasks that need to be performed after deployment.

[optional] Additional Reviewer Notes or Considerations?

@thatmitchcanter
Copy link
Contributor

Task linked: WDSBT-241 Create Custom Card Variation Pattern(s)
Task linked: WDSBT-262 Card Variation Pattern #5

@thatmitchcanter
Copy link
Contributor

Task linked: WDSBT-263 Card Variation Pattern #6

@thatmitchcanter
Copy link
Contributor

Task linked: WDSBT-264 Card Variation Pattern #9

@thatmitchcanter
Copy link
Contributor

Task linked: WDSBT-265 Card Variation Pattern #11

@lepittenger lepittenger changed the title Feature/wdsbt 262 card variation 5 Cards 5, 6, 9, 11 Apr 24, 2025
@lepittenger lepittenger changed the title Cards 5, 6, 9, 11 Cards 5, 6, 9, 11, 18 Apr 24, 2025
@thatmitchcanter
Copy link
Contributor

Task linked: WDSBT-267 Card Variation Pattern #18

@lepittenger lepittenger changed the base branch from feature/WDSBT-241-Design-System-Cards to release/patterns April 25, 2025 19:11
@lepittenger lepittenger changed the title Cards 5, 6, 9, 11, 18 Cards 5, 6, 9, 11, 18, 20, 21, 27, 43, 44 Apr 25, 2025
@thatmitchcanter
Copy link
Contributor

Task linked: WDSBT-269 Card Variation Pattern #20
Task linked: WDSBT-270 Card Variation Pattern #21
Task linked: WDSBT-272 Card Variation Pattern #27
Task linked: WDSBT-281 Card Variation Pattern #43
Task linked: WDSBT-282 Card Variation Pattern #44

@thatmitchcanter
Copy link
Contributor

Task linked: WDSBT-280 Card Variation Pattern #42

@lepittenger lepittenger changed the title Cards 5, 6, 9, 11, 18, 20, 21, 27, 43, 44 Cards 5, 6, 9, 11, 18, 20, 21, 27, 42, 43, 44 Apr 25, 2025
@thatmitchcanter
Copy link
Contributor

Task linked: WDSBT-283 Card Variation Pattern Mobile Content Block

@lepittenger lepittenger changed the title Cards 5, 6, 9, 11, 18, 20, 21, 27, 42, 43, 44 Cards 5, 6, 9, 11, 18, 20, 21, 27, 42, 43, 44, "mobile content block" Apr 25, 2025
@lepittenger lepittenger marked this pull request as ready for review April 25, 2025 21:17
@lepittenger lepittenger requested a review from khleomix as a code owner April 25, 2025 21:17
@lepittenger lepittenger changed the base branch from release/patterns to feature/WDSBT-241-Design-System-Cards April 25, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khleomix khleomix Awaiting requested review from khleomix khleomix is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lepittenger @thatmitchcanter