Support unix-based X11 server connections as well as TCP-based ones #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you should add some mention about this in the user facing config documentation: https://github.com/WebFreak001/code-debug/blob/eb9f5e4dd7dc64f6e6e8a40115d47d30e522525c/package.json |
Typically, on unix systems, local X11 is connected through the socket `/tmp/.X11-unix/X0`, as indicated by the missing host name part in `DISPLAY=:0` or `DISPLAY=:0.0`. WSLg (the X11 implementation provided with WSL in Microsoft Windows) does not listen on the TCP socket localhost:6000, but on the Unix socket only. So this commit enables SSH X11 forwarding to connect to the unix domain socket if the X server host name is set to the empty string.
WebFreak001
approved these changes
Mar 31, 2025
|
Oh, is that possibly a step for the next release? Note: the last one is over a year old and we have a bunch of bugfixes and features, see Changelog (this one still needs to be added) from the diff v0.27.0...master (note: #448 is mostly ready to get in as well). So @WebFreak001: any chance for a release (which is still done and then published to the stores by yourself), soon? |
|
the store publishing should be part of GH actions, no? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically, on unix systems, local X11 is connected through the socket
/tmp/.X11-unix/X0, as indicated by the missing host name part inDISPLAY=:0orDISPLAY=:0.0. WSLg (the X11 implementation provided with WSL in Microsoft Windows) does not listen on the TCP socket localhost:6000, but on the Unix socket only.So this pull request enables SSH X11 forwarding to connect to the unix domain socket if the X server host name is set to the empty string.