-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add end2end tests #470
base: main
Are you sure you want to change the base?
Add end2end tests #470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, this looks good to me
I only have a few nits before landing :) see comments below
thanks for the new tests!
Updated a few more things
|
Thanks, I like the fact we call a function better (didn't want to highlight it before :-) ) BTW I wonder if there's a way to run the tests headless too. How does it work on CI, is there a X server or something? |
headless would mostly depend on how the browser is set up. Given that we currently only run on macOs it wont matter for the official testing (there is no real headless on macOS I think). |
SpeedometerReady
andSpeedometerDone
events for easier testing