Skip to content

Conversation

@iFergal
Copy link
Collaborator

@iFergal iFergal commented Nov 12, 2025

The ExchangeCueDoer is hooked up to our 3902 parser so that any successfully parsed and saved exchanges get indexed in the DB afterwards.

This PR hooks up the Exchanger to the parsing call in /identifiers/{name}/exchanges so that the same happens for outbound exchanges.

This means we can properly find exns we have sent using /exchanges/query (this exists in KERIA but not Signify - we are using it on our Signify fork).

@lenkan On main this doesn't need to be applied to IPEX as it's using parser instead of hby.psr but you reverted that in your PR. Once we have aligned on how to handle that there, we can consolidate everything.

@iFergal iFergal requested review from kentbull and lenkan November 12, 2025 14:55
@iFergal iFergal self-assigned this Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.89%. Comparing base (1f22907) to head (838775c).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
+ Coverage   86.60%   86.89%   +0.29%     
==========================================
  Files          25       25              
  Lines        5286     5442     +156     
==========================================
+ Hits         4578     4729     +151     
- Misses        708      713       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@kentbull kentbull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@kentbull
Copy link
Collaborator

This also needs to be rebased.

@kentbull
Copy link
Collaborator

This is failing due to the macos-13 requirement. You can just change that to macos-15 and rerun.

@kentbull
Copy link
Collaborator

After a rebase this one can be quickly merged.

@iFergal iFergal merged commit 54611c9 into WebOfTrust:main Dec 11, 2025
6 checks passed
@iFergal iFergal deleted the feat/indexOutboundExns branch December 11, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants