Skip to content

Conversation

@iFergal
Copy link
Collaborator

@iFergal iFergal commented Dec 9, 2025

macos-13 runners are now deprecated: actions/runner-images#13046

@iFergal iFergal requested review from kentbull and lenkan December 9, 2025 17:04
@iFergal iFergal self-assigned this Dec 9, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.89%. Comparing base (1f22907) to head (9526ab5).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
+ Coverage   86.60%   86.89%   +0.29%     
==========================================
  Files          25       25              
  Lines        5286     5442     +156     
==========================================
+ Hits         4578     4729     +151     
- Misses        708      713       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iFergal iFergal marked this pull request as draft December 9, 2025 17:09
@iFergal iFergal removed request for kentbull and lenkan December 9, 2025 17:09
@kentbull kentbull marked this pull request as ready for review December 10, 2025 01:17
@kentbull
Copy link
Collaborator

Looks like this is failing on the macos-13 runner. We should merge it anyway.

@iFergal iFergal requested a review from lenkan December 10, 2025 10:45
@lenkan
Copy link
Collaborator

lenkan commented Dec 10, 2025

Looks like this is failing on the macos-13 runner. We should merge it anyway.

It is actually not failing, it is waiting for the status for test (macos-13) to be reported. This is a setting under the branch protection rules which can only be changed by administrators. It needs to be updated to select the new status check name, which is test (macos-15), or use some sort of wildcard.

@kentbull
Copy link
Collaborator

Oh, I missed that. I'll take a closer look a little later today.

@lenkan lenkan merged commit dae95ce into WebOfTrust:main Dec 10, 2025
6 checks passed
@iFergal iFergal deleted the chore/upgradeMacOsRunner branch January 6, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants