Skip to content

Conversation

@Sotatek-Patrick-Vu
Copy link
Contributor

  • transferable, windexes and state are not returned in list method but only get method, so we should make them to be optional
  • Rename Identifier schema to HabState and split it to 2 version: full type for Get method and short type for List method

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.97%. Comparing base (568fbb5) to head (6992230).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
+ Coverage   86.91%   86.97%   +0.05%     
==========================================
  Files          25       25              
  Lines        5451     5459       +8     
==========================================
+ Hits         4738     4748      +10     
+ Misses        713      711       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iFergal iFergal changed the title Fix HabState type fix: split HabState in 2 types to account for optional attributes Jan 9, 2026
@iFergal iFergal requested review from kentbull and lenkan January 12, 2026 08:59
@iFergal iFergal merged commit 262b7ce into WebOfTrust:main Jan 14, 2026
6 checks passed
@kentbull
Copy link
Collaborator

Thanks @lenkan . I had reviewed this and forgot to click Approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants