Skip to content

fix: session status stuck on Connection in progress on devices without GMS #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SERDUN merged 2 commits into from
Apr 10, 2026
Merged

fix: session status stuck on Connection in progress on devices without GMS #1092

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d7a92d
fix: seed initial push tokens and call state in SessionStatusCubit
SERDUN Apr 10, 2026
e2ab14b
refactor: remove unused optional params from _emitCombinedStatus
SERDUN Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/features/session_status/bloc/session_status_cubit.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,12 @@ final _logger = Logger('SessionStatusCubit');
class SessionStatusCubit extends Cubit<SessionStatusState> {
SessionStatusCubit({required PushTokensBloc pushTokensBloc, required CallBloc callBloc})
: super(const SessionStatusState()) {
_lastPushTokensState = pushTokensBloc.state;
_lastCallState = callBloc.state;
_pushTokensSubscription = pushTokensBloc.stream.listen(_onPushTokensChanged);
_callSubscription = callBloc.stream.listen(_onCallChanged);

_emitCombinedStatus(pushTokensBloc.state, callBloc.state);
_emitCombinedStatus();
Comment thread
SERDUN marked this conversation as resolved.
}

late final StreamSubscription<PushTokensState> _pushTokensSubscription;
Expand All @@ -38,11 +40,11 @@ class SessionStatusCubit extends Cubit<SessionStatusState> {
_emitCombinedStatus();
}

void _emitCombinedStatus([PushTokensState? initialPushTokens, CallState? initialCall]) {
void _emitCombinedStatus() {
_logger.finest('emitCombinedStatus: $_lastPushTokensState, $_lastCallState');

final pushTokens = initialPushTokens ?? _lastPushTokensState;
final call = initialCall ?? _lastCallState;
final pushTokens = _lastPushTokensState;
final call = _lastCallState;

if (pushTokens != null && call != null) {
emit(state.copyWith(status: _mapCallStatusToSessionStatus(call.status, pushTokens)));
Expand Down
Loading