fix(session): resolve stuck 'No internet' status after network restore#1095
Merged
Conversation
When SignalingConnecting fires after a failed connection attempt,
lastSignalingClientConnectError and lastSignalingDisconnectCode were
not cleared. This left the status stuck on connectError/connectIssue
('Connection error' / 'Connection issue') even though a fresh connect
attempt was already in progress.
After this fix, SignalingConnecting resets all stale error fields so
the status correctly shows inProgress ('Connection in progress') for
the duration of the reconnect.
There was a problem hiding this comment.
Pull request overview
Fixes an incorrect UI connection status that could remain stuck on “Connection error/issue” after network recovery by clearing stale signaling error fields as soon as a new reconnect attempt begins, aligning Connecting behavior with the existing Connected cleanup.
Changes:
- Clear
lastSignalingClientConnectErrorwhen a newSignalingClientStatus.connectingevent is handled. - Clear
lastSignalingDisconnectCodewhen a newSignalingClientStatus.connectingevent is handled.
digiboridev
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After turning internet off and back on, the app status gets stuck on "Connection error" or "Connection issue" even though a fresh reconnect attempt is already in progress.
Observed on: Samsung SM-M325FV, Android 13
Log:
samsung-SM-M325FV-Android-13_2026-04-10_130044.logcatRoot Cause
__onSignalingClientEventConnectingincall_bloc.dartcleared onlylastSignalingClientDisconnectErrorbut leftlastSignalingClientConnectErrorandlastSignalingDisconnectCodefrom the previous failed session:CallServiceState.get statusevaluates these fields in priority order:So even when a fresh
SignalingConnectingfires and the module is actively reconnecting, the UI shows "Connection error" or "Connection issue" untilSignalingConnectedclears them.Fix
Clear all stale error fields in
__onSignalingClientEventConnecting:As soon as a new connect attempt starts, the status correctly reflects
inProgress("Connection in progress") for the entire reconnect window.Scope
call_bloc.dartSignalingConnectedalready clears these fields — this fix mirrors that behavior one step earlier (atConnecting)