Skip to content

docs(signaling): add remoteMessaging FGS type rationale #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SERDUN merged 3 commits into from
Apr 10, 2026
Merged

docs(signaling): add remoteMessaging FGS type rationale #1098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35a8639
docs(signaling): document why remoteMessaging is the correct FGS type
SERDUN Apr 10, 2026
5e75416
docs(signaling): tighten remoteMessaging comments — positive rational…
SERDUN Apr 10, 2026
1b50163
docs(signaling): clarify remoteMessaging type is passed not declared …
SERDUN Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ..._signaling_service/webtrit_signaling_service_android/android/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,18 @@
<uses-permission android:name="android.permission.POST_NOTIFICATIONS" />

<application>
<!--
SignalingForegroundService uses foregroundServiceType="remoteMessaging".

This service maintains a persistent WebSocket connection to the WebTrit signaling
server to exchange call-signaling messages (SDP, ICE candidates, call state events).
The remoteMessaging type is defined by Android as the appropriate type for services
that keep a long-running connection alive so a remote server can deliver messages to
the device at any time — which is exactly what this service does.

Required permission: FOREGROUND_SERVICE_REMOTE_MESSAGING (declared above).
Applies on Android 14+ (API 34+); older versions pass type=0.
-->
<service
android:name=".SignalingForegroundService"
android:foregroundServiceType="remoteMessaging"
Expand Down
6 changes: 6 additions & 0 deletions ...droid/android/src/main/kotlin/com/webtrit/signaling_service/SignalingForegroundService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,12 @@ class SignalingForegroundService : Service() {
.setPriority(NotificationCompat.PRIORITY_LOW)
.build()

// FOREGROUND_SERVICE_TYPE_REMOTE_MESSAGING: this service maintains a persistent
// WebSocket to the WebTrit signaling server so it can receive call-signaling
// messages (SDP, ICE candidates, call events) at any time. The remoteMessaging
// type is the Android-defined category for exactly this use case.
// Passed to startForeground() on API 34+ only; older versions pass 0 and do
// not enforce a foreground service type here.
ServiceCompat.startForeground(
this,
NOTIFICATION_ID,
Expand Down
Loading