fix: ensure system info is loaded before MainShell builds#1105
Merged
Conversation
CallerIdSettingsRepository.create and another provider create: in main_shell.dart call getLocalSystemInfo() synchronously. If system info is absent (cleared during session cleanup after FGS failure, or never fetched in this session) the provider throws StateError and crashes the app. Add a getSystemInfo(cacheFirst) call to onMainShellRouteGuardNavigation, executed after the auth check and before navigation resolves. If system info cannot be loaded — no cache and network unreachable — redirect to the login screen. This prevents the crash observed on Xiaomi after FGS recovery: CallerIdSettingsRepository.create → getLocalSystemInfo() → StateError: "No system info in cache" (main_shell.dart:257)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After an FGS failure (e.g. Xiaomi "did not start in time"), the app could crash with:
Root cause:
CallerIdSettingsRepository.create(and one other provider at line 176) callgetLocalSystemInfo()synchronously. TheMainShellRouteguard only checked for a valid session token — it did not verify that system info was actually in the cache.After FGS failure the app can reach
MainShellRouteinauthenticatedstate (session token still in SecureStorage) while system info is absent — either becauseuserSessionCleanupResolver.clear()ran in a previous process, or because the initial info fetch was interrupted beforesetSystemInfo()completed.Fix
Add
getSystemInfo(cacheFirst)toonMainShellRouteGuardNavigation, executed after the auth check:SystemInfoRepositoryis injected intoAppRoutervia constructor.Test plan