chore: remove deprecated setLogsDelegate calls from webtrit_phone#1251
Draft
chore: remove deprecated setLogsDelegate calls from webtrit_phone#1251
Conversation
Switches to native file logging — no longer routing callkeep logs through Flutter delegate channels.
- AppPath: add logFilePath getter (single source of truth for app_logs.log) - LogRecordsRepository: accept logFilePath instead of directory path - bootstrap: use appPath.logFilePath instead of temporaryPath - main_shell: use appPath.logFilePath for CallkeepAndroidOptions.logFilePath
…e watch
NativeLogForwarder watches _native.log via Directory.watch() (inotify).
On file change it reads new lines and emits them through Logger('callkeep'),
which routes to RotatingFileAppender (app_logs.log) and Logz.io appender.
AppPath exposes nativeLogFilePath. cleanLogs() also deletes the native files.
- Add NativeLogForwarder to IsolateContext so native logs are captured even when the main isolate is not active; PushIsolateContext reuses the same forwarder via super to avoid duplication - Log SEVERE callkeep records to Crashlytics recordError (not just breadcrumb) - Fix silent catch in NativeLogForwarder: re-log via _logger.warning - Add unit tests for NativeLogForwarder covering level parsing, blank-line skipping, incremental forwarding, truncation reset, and dispose - Document .1 rotation limit in cleanLogs and nativeLogFilePath getter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches to native file logging — no longer routing callkeep logs through Flutter delegate channels.
Previously
CallkeepLogswas wired up as asetLogsDelegatesubscriber so Kotlin logs would flow back through the Flutter channel into the Dart logging system. This coupled log visibility to the Flutter isolate lifecycle.Now Kotlin services write directly to the shared log file and Android logcat unconditionally (handled in webtrit_callkeep). The delegate bridge is no longer needed on the Flutter side.