feat(app): inject external theme and feature config into the embedded app#1439
Closed
SERDUN wants to merge 1 commit into
Closed
feat(app): inject external theme and feature config into the embedded app#1439SERDUN wants to merge 1 commit into
SERDUN wants to merge 1 commit into
Conversation
… app Stacked on the embeddedPreview bootstrap. RootApp/App accept external ThemeSettings/ThemeMode/FeatureAccess streams (+ initial seeds) so an embedder (the configurator's realtime preview) can drive the live appearance and feature/login/tab config of the embedded app. - App subscribes to the external theme streams and applies them via AppThemeSettingsChanged/AppThemeModeChanged (no prefs write); subscriptions are cancelled on dispose. - RootApp's FeatureAccess StreamProvider source is swapped to the external stream (with the external initial as the first-frame seed) when provided. Standalone behaviour is unchanged: all external streams default to null.
Member
Author
|
Closing — reworking the embedded-host support into a cleaner single abstraction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Stacked on #1438 (Firebase-free
embeddedPreviewbootstrap). Lets an embedder — the configurator's realtime preview — drive the live appearance and feature/login/tab config of the embedded app.RootApp/Appaccept externalThemeSettings/ThemeMode/FeatureAccessstreams (+ initial seeds).Appsubscribes to the theme streams and applies them viaAppThemeSettingsChanged/AppThemeModeChanged(no prefs write); subscriptions are cancelled on dispose.RootApp'sFeatureAccessStreamProvidersource is swapped to the external stream, with the external initial as the first-frame seed.Why
Second half of the embedded-host support for the realtime-preview epic (split from #1437). Depends on #1438 for the
embeddedPreviewflag / Firebase-free bootstrap.Notes
null.flutter analyze libgreen.