fix(signaling): add null safety guards to JSON event parsing (WT-599)#963
Closed
SERDUN wants to merge 1 commit into
Closed
fix(signaling): add null safety guards to JSON event parsing (WT-599)#963SERDUN wants to merge 1 commit into
SERDUN wants to merge 1 commit into
Conversation
Prevent _TypeError crashes ('Null' is not a subtype of 'String') in
signaling event deserialization when server sends malformed or incomplete
JSON messages. This addresses the critical incident pattern with 337
occurrences across PortaPhone, Signal Connect, Vox OmniOne, and Call Home.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent
_TypeErrorcrashes ('Null'is not a subtype of'String') in signaling event deserialization when the server sends malformed or incomplete JSON messages. This addresses the critical incident pattern with 337 occurrences across PortaPhone, Signal Connect, Vox OmniOne, and Call Home.Crash Prevention Summary
call_id,user_active_calls, etc.)Key Changes
as Type? ?? defaultfallbacks forString,int, andboolfields (e.g.,call_id,remote_number,keepalive_interval).as Listcasts withas List<dynamic>? ?? []. Implemented.whereType<T>()to prevent internal element cast crashes.Enum.values.byName()withtry-catchwrappers to provide safe default values fornullor unknown server strings.candidateinIceTrickleEvent).Branch:
fix/signaling-null-safety-guards| Commit:b5e66657